Skip to content

Commit fd92567

Browse files
committed
Add TODO for deferred Review comment
1 parent 89bc095 commit fd92567

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ext/pdo/pdo_stmt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ static bool do_fetch(pdo_stmt_t *stmt, zval *return_value, enum pdo_fetch_type h
756756
/* This used to use try_convert_to_string() which would silently support integers, floats, null
757757
* even if any such value could not generate a valid class name, as no class was found it would
758758
* then proceed to use stdClass */
759+
// TODO Raise PDO implementation error when the column name is not a string
759760
if (Z_TYPE(ce_name_from_column) == IS_STRING) {
760761
ce = zend_lookup_class(Z_STR(ce_name_from_column));
761762
}

0 commit comments

Comments
 (0)