Skip to content

Commit fbc495d

Browse files
committed
Remove usage of float keys in arrays
Also make test output not produce trailling whitespaces
1 parent 23bb956 commit fbc495d

File tree

81 files changed

+1856
-2494
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+1856
-2494
lines changed

ext/standard/tests/array/005.phpt

Lines changed: 199 additions & 142 deletions
Large diffs are not rendered by default.

ext/standard/tests/array/009.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ $varient_arrays = array (
2020
array(NULL),// array with NULL
2121
array(null),// array with null
2222
array(NULL, true, null, "", 1), // mixed array
23-
array(-1.5 => "test", -2 => "rest", 2.5 => "two",
23+
array(-1 => "test", -2 => "rest", 2 => "two",
2424
"" => "string", 0 => "zero", "" => "" ) // mixed array
2525
);
2626

ext/standard/tests/array/array_change_key_case_variation3.phpt

Lines changed: 9 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,6 @@ $inputs = array(
2929
-2345 => 'negative',
3030
),
3131

32-
// float data
33-
/*2*/ 'float' => array(
34-
10.5 => 'positive',
35-
-10.5 => 'negative',
36-
.5 => 'half',
37-
),
38-
39-
'extreme floats' => array(
40-
12.3456789000e6 => 'large',
41-
12.3456789000E-10 => 'small',
42-
),
43-
4432
// null data
4533
/*3*/ 'null uppercase' => array(
4634
NULL => 'null 1',
@@ -110,65 +98,47 @@ array(4) {
11098
string(8) "negative"
11199
}
112100

113-
-- Iteration 2 : float data --
114-
array(3) {
115-
[10]=>
116-
string(8) "positive"
117-
[-10]=>
118-
string(8) "negative"
119-
[0]=>
120-
string(4) "half"
121-
}
122-
123-
-- Iteration 3 : extreme floats data --
124-
array(2) {
125-
[12345678]=>
126-
string(5) "large"
127-
[0]=>
128-
string(5) "small"
129-
}
130-
131-
-- Iteration 4 : null uppercase data --
101+
-- Iteration 2 : null uppercase data --
132102
array(1) {
133103
[""]=>
134104
string(6) "null 1"
135105
}
136106

137-
-- Iteration 5 : null lowercase data --
107+
-- Iteration 3 : null lowercase data --
138108
array(1) {
139109
[""]=>
140110
string(6) "null 2"
141111
}
142112

143-
-- Iteration 6 : bool lowercase data --
113+
-- Iteration 4 : bool lowercase data --
144114
array(2) {
145115
[1]=>
146116
string(6) "lowert"
147117
[0]=>
148118
string(6) "lowerf"
149119
}
150120

151-
-- Iteration 7 : bool uppercase data --
121+
-- Iteration 5 : bool uppercase data --
152122
array(2) {
153123
[1]=>
154124
string(6) "uppert"
155125
[0]=>
156126
string(6) "upperf"
157127
}
158128

159-
-- Iteration 8 : empty double quotes data --
129+
-- Iteration 6 : empty double quotes data --
160130
array(1) {
161131
[""]=>
162132
string(6) "emptyd"
163133
}
164134

165-
-- Iteration 9 : empty single quotes data --
135+
-- Iteration 7 : empty single quotes data --
166136
array(1) {
167137
[""]=>
168138
string(6) "emptys"
169139
}
170140

171-
-- Iteration 10 : string data --
141+
-- Iteration 8 : string data --
172142
array(3) {
173143
["STRINGD"]=>
174144
string(7) "stringd"
@@ -178,13 +148,13 @@ array(3) {
178148
string(7) "stringh"
179149
}
180150

181-
-- Iteration 11 : undefined data --
151+
-- Iteration 9 : undefined data --
182152
array(1) {
183153
[""]=>
184154
string(9) "undefined"
185155
}
186156

187-
-- Iteration 12 : unset data --
157+
-- Iteration 10 : unset data --
188158
array(1) {
189159
[""]=>
190160
string(5) "unset"

ext/standard/tests/array/array_chunk_variation5.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ echo "*** Testing array_chunk() : usage variations ***\n";
1616
$input_array = array(1, 2, 3);
1717

1818
// different magnitude's
19-
$sizes = array(-1, count($input_array) + 1, 0, 1.5);
19+
$sizes = array(-1, count($input_array) + 1, 0, 1);
2020

2121
// loop through the array for size argument
2222
foreach ($sizes as $size){
@@ -86,7 +86,7 @@ array_chunk(): Argument #2 ($length) must be greater than 0
8686
array_chunk(): Argument #2 ($length) must be greater than 0
8787
array_chunk(): Argument #2 ($length) must be greater than 0
8888

89-
-- Testing array_chunk() when size = 1.5 --
89+
-- Testing array_chunk() when size = 1 --
9090
array(3) {
9191
[0]=>
9292
array(1) {

ext/standard/tests/array/array_combine_variation4.phpt

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,6 @@ $arrays = array (
4040
array(1 => "1"),
4141
array(1 => "1", 2 => "2", 3 => "3", 4 => "4"),
4242

43-
// arrays with float keys
44-
/*5*/ array(2.3333 => "float"),
45-
array(1.2 => "f1", 3.33 => "f2",
46-
4.89999922839999 => "f3",
47-
33333333.333333 => "f4"),
48-
4943
// arrays with string keys
5044
/*7*/ array('\tHello' => 111, 're\td' => "color",
5145
'\v\fworld' => 2.2, 'pen\n' => 33),
@@ -112,22 +106,6 @@ array(4) {
112106
string(1) "4"
113107
}
114108
-- Iteration 5 --
115-
array(1) {
116-
["float"]=>
117-
string(5) "float"
118-
}
119-
-- Iteration 6 --
120-
array(4) {
121-
["f1"]=>
122-
string(2) "f1"
123-
["f2"]=>
124-
string(2) "f2"
125-
["f3"]=>
126-
string(2) "f3"
127-
["f4"]=>
128-
string(2) "f4"
129-
}
130-
-- Iteration 7 --
131109
array(4) {
132110
[111]=>
133111
int(111)
@@ -138,7 +116,7 @@ array(4) {
138116
[33]=>
139117
int(33)
140118
}
141-
-- Iteration 8 --
119+
-- Iteration 6 --
142120
array(4) {
143121
[111]=>
144122
int(111)
@@ -149,21 +127,21 @@ array(4) {
149127
[33]=>
150128
int(33)
151129
}
152-
-- Iteration 9 --
130+
-- Iteration 7 --
153131
array(2) {
154132
["hello"]=>
155133
string(5) "hello"
156134
["string"]=>
157135
string(6) "string"
158136
}
159-
-- Iteration 10 --
137+
-- Iteration 8 --
160138
array(2) {
161139
["hello"]=>
162140
string(5) "hello"
163141
["resource"]=>
164142
string(8) "resource"
165143
}
166-
-- Iteration 11 --
144+
-- Iteration 9 --
167145
array(7) {
168146
[1]=>
169147
int(1)

ext/standard/tests/array/array_combine_variation5.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ $arrays = array (
4646
array("f1" => 1.2, 'f2' => 3.33, 3 => 4.89999922839999, 'f4' => 33333333.333),
4747

4848
// arrays with string values
49-
/*7*/ array(111 => "\tHello", "red" => "col\tor", 2 => "\v\fworld", 3.3 => "pen\n"),
50-
array(111 => '\tHello', "red" => 'col\tor', 2 => '\v\fworld', 3.3 => 'pen\n'),
49+
/*7*/ array(111 => "\tHello", "red" => "col\tor", 2 => "\v\fworld", 3 => "pen\n"),
50+
array(111 => '\tHello', "red" => 'col\tor', 2 => '\v\fworld', 3 => 'pen\n'),
5151
array(1 => "hello", "heredoc" => $heredoc),
5252

5353
// array with object, unset variable and resource variable

ext/standard/tests/array/array_diff_assoc_variation4.phpt

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,6 @@ $inputs = array(
3131
12345 => 'positive',
3232
-2345 => 'negative'),
3333

34-
// float data
35-
/*2*/
36-
'float' => array(
37-
10.5 => 'float 1',
38-
-10.5 => 'float 2',
39-
.5 => 'float 3'),
40-
4134
// null data
4235
/*3*/
4336
'null' => array(
@@ -109,58 +102,48 @@ array(4) {
109102
}
110103

111104
-- Iteration 2 --
112-
array(3) {
113-
[10]=>
114-
string(7) "float 1"
115-
[-10]=>
116-
string(7) "float 2"
117-
[0]=>
118-
string(7) "float 3"
119-
}
120-
121-
-- Iteration 3 --
122105
array(1) {
123106
[""]=>
124107
string(6) "null 2"
125108
}
126109

127-
-- Iteration 4 --
110+
-- Iteration 3 --
128111
array(2) {
129112
[1]=>
130113
string(5) "boolT"
131114
[0]=>
132115
string(5) "boolF"
133116
}
134117

135-
-- Iteration 5 --
118+
-- Iteration 4 --
136119
array(1) {
137120
[""]=>
138121
string(6) "emptys"
139122
}
140123

141-
-- Iteration 6 --
124+
-- Iteration 5 --
142125
array(2) {
143126
["string"]=>
144127
string(7) "strings"
145128
["hello world"]=>
146129
string(7) "stringh"
147130
}
148131

149-
-- Iteration 7 --
132+
-- Iteration 6 --
150133
array(2) {
151134
["binary1"]=>
152135
string(8) "binary 1"
153136
["binary2"]=>
154137
string(8) "binary 2"
155138
}
156139

157-
-- Iteration 8 --
140+
-- Iteration 7 --
158141
array(1) {
159142
[""]=>
160143
string(9) "undefined"
161144
}
162145

163-
-- Iteration 9 --
146+
-- Iteration 8 --
164147
array(1) {
165148
[""]=>
166149
string(5) "unset"

ext/standard/tests/array/array_diff_assoc_variation5.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Test array_diff_assoc() function : usage variations - compare integers, floats a
88

99
echo "*** Testing array_diff_assoc() : usage variations ***\n";
1010
$arr_default_int = array(1, 2, 3, 'a');
11-
$arr_float = array(0 => 1.00, 1.00 => 2.00, 2.00 => 3.00, 'b');
11+
$arr_float = array(0 => 1.00, 1 => 2.00, 2 => 3.00, 'b');
1212
$arr_string = array('1', '2', '3', 'c');
1313
$arr_string_float = array('0' => '1.00', '1.00' => '2.00', '2.00' => '3.00', 'd');
1414

ext/standard/tests/array/array_diff_key_variation5.phpt

Lines changed: 0 additions & 27 deletions
This file was deleted.

ext/standard/tests/array/array_diff_uassoc_variation10.phpt

Lines changed: 0 additions & 39 deletions
This file was deleted.

ext/standard/tests/array/array_diff_uassoc_variation5.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ echo "*** Testing array_diff_uassoc() : usage variation ***\n";
66

77
//Initialize variables
88
$arr_default_int = array(1, 2, 3, 4);
9-
$arr_float = array(0 => 1.00, 1.00 => 2.00, 2.00 => 3.00, 3.00 => 4.00);
9+
$arr_float = array(0 => 1.00, 1 => 2.00, 2 => 3.00, 3 => 4.00);
1010

1111

1212
function key_compare_func($key1, $key2)

ext/standard/tests/array/array_diff_uassoc_variation6.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Test array_diff_uassoc() function : usage variation - Comparing floating points
55
echo "*** Testing array_diff_uassoc() : usage variation ***\n";
66

77
//Initialize variables
8-
$arr_float = array(0 => 1.00, 1.00 => 2.00);
8+
$arr_float = array(0 => 1.00, 1 => 2.00);
99
$arr_string_int = array('1', '2');
1010
$arr_string_float = array('0' => '1.00', '1.00' => '2.00');
1111

0 commit comments

Comments
 (0)