Use ZEND_BYTES_SWAP32() for php_pack_reverse_int32()

nielsdos · nielsdos · commit fafcaa393cdf · 2025-05-18T20:29:44.000+02:00
diff --git a/ext/standard/pack.c b/ext/standard/pack.c
@@ -99,10 +99,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)
 /* {{{ php_pack_reverse_int32 */
 ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)
 {
-	uint32_t result;
-	result = ((arg & 0xFF) << 24) | ((arg & 0xFF00) << 8) | ((arg >> 8) & 0xFF00) | ((arg >> 24) & 0xFF);
-
-	return result;
+	return ZEND_BYTES_SWAP32(arg);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -99,10 +99,7 @@ ZEND_ATTRIBUTE_CONST static inline uint16_t php_pack_reverse_int16(uint16_t arg)`
`99`	`99`	`/* {{{ php_pack_reverse_int32 */`
`100`	`100`	`ZEND_ATTRIBUTE_CONST static inline uint32_t php_pack_reverse_int32(uint32_t arg)`
`101`	`101`	`{`
`102`		`- uint32_t result;`
`103`		`- result = ((arg & 0xFF) << 24) \| ((arg & 0xFF00) << 8) \| ((arg >> 8) & 0xFF00) \| ((arg >> 24) & 0xFF);`
`104`		`-`
`105`		`- return result;`
	`102`	`+ return ZEND_BYTES_SWAP32(arg);`
`106`	`103`	`}`
`107`	`104`	`/* }}} */`
`108`	`105`