Skip to content

Commit f985667

Browse files
committed
sid can never be NULL because it was NULL-checked earlier
1 parent 0c0b41d commit f985667

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

ext/session/mod_files.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -674,10 +674,8 @@ PS_CREATE_SID_FUNC(files)
674674
/* Check collision */
675675
/* FIXME: mod_data(data) should not be NULL (User handler could be NULL) */
676676
if (data && ps_files_key_exists(data, sid) == SUCCESS) {
677-
if (sid) {
678-
zend_string_release_ex(sid, 0);
679-
sid = NULL;
680-
}
677+
zend_string_release_ex(sid, 0);
678+
sid = NULL;
681679
if (--maxfail < 0) {
682680
return NULL;
683681
}

0 commit comments

Comments
 (0)