Support ephemeral ports in debug server

Author: sgolemon

sapi/cli/php_cli_server.c

@@ -2353,7 +2353,81 @@ static void php_cli_server_client_dtor_wrapper(zval *zv) /* {{{ */
 	pefree(p, 1);
 } /* }}} */
 
-static int php_cli_server_ctor(php_cli_server *server, const char *addr, const char *document_root, const char *router) /* {{{ */
+/**
+ * Parse the host and port portions of an address specifier in
+ * one of the following forms:
+ * - hostOrIP
+ * - [hostOrIp]
+ * - hostOrIP:port
+ * - [hostOrIP]:port
+ */
+static char *php_cli_server_parse_addr(const char *addr, int *pport) {
+	const char *p, *end;
+	long port;
+
+	if (addr[0] == '[') {
+		/* Encapsulated [hostOrIP]:port or just [hostOrIP] */
+		const char *start = addr + 1;
+		end = strchr(start, ']');
+		if (!end) {
+			/* No ending ] delimiter to match [ */
+			return NULL;
+		}
+
+		p = end + 1;
+		if (*p == '\0') {
+			/* host only, implied port 0 */
+			*pport = 0;
+			return pestrndup(start, end - start, 1);
+		}
+
+		if (*p != ':') {
+			/* Invalid char following address */
+			return NULL;
+		}
+
+		port = strtol(p + 1, (char**)&p, 10);
+		if (p && *p) {
+			/* Non-numeric in port */
+			return NULL;
+		}
+		if (port < 0 || port > 65535) {
+			/* Invalid port */
+			return NULL;
+		}
+
+		/* Full [hostOrIP]:port provided */
+		*pport = (int)port;
+		return pestrndup(start, end - start, 1);
+	}
+
+	end = strchr(addr, ':');
+	if (!end) {
+		/* host only, implied port 0 */
+		*pport = 0;
+		return pestrdup(addr, 1);
+	}
+
+	if (strchr(end + 1, ':')) {
+		/* Probably a bare IPv6 */
+		*pport = 0;
+		return pestrdup(addr, 1);
+	}
+
+	port = strtol(end + 1, (char**)&p, 10);
+	if (p && *p) {
+		/* Non-numeric port */
+		return NULL;
+	}
+	if (port < 0 || port > 65535) {
+		/* Invalid port */
+		return NULL;
+	}
+	*pport = (int)port;
+	return pestrndup(addr, end - addr, 1);
+}
+
+static int php_cli_server_ctor(php_cli_server *server, const char *addr, const char *document_root, const char *router, const char **phost, int *pport) /* {{{ */
 {
 	int retval = SUCCESS;
 	char *host = NULL;
@@ -2363,40 +2437,9 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
 	int err = 0;
 	int port = 3000;
 	php_socket_t server_sock = SOCK_ERR;
-	char *p = NULL;
 
-	if (addr[0] == '[') {
-		host = pestrdup(addr + 1, 1);
-		if (!host) {
-			return FAILURE;
-		}
-		p = strchr(host, ']');
-		if (p) {
-			*p++ = '\0';
-			if (*p == ':') {
-				port = strtol(p + 1, &p, 10);
-				if (port <= 0 || port > 65535) {
-					p = NULL;
-				}
-			} else if (*p != '\0') {
-				p = NULL;
-			}
-		}
-	} else {
-		host = pestrdup(addr, 1);
-		if (!host) {
-			return FAILURE;
-		}
-		p = strchr(host, ':');
-		if (p) {
-			*p++ = '\0';
-			port = strtol(p, &p, 10);
-			if (port <= 0 || port > 65535) {
-				p = NULL;
-			}
-		}
-	}
-	if (!p) {
+	host = php_cli_server_parse_addr(addr, &port);
+	if (!host) {
 		fprintf(stderr, "Invalid address: %s\n", addr);
 		retval = FAILURE;
 		goto out;
@@ -2457,7 +2500,14 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
 
 	server->is_running = 1;
 out:
-	if (retval != SUCCESS) {
+	if (retval == SUCCESS) {
+		if (phost) {
+			*phost = host;
+		}
+		if (pport) {
+			*pport = port;
+		}
+	} else {
 		if (host) {
 			pefree(host, 1);
 		}
@@ -2644,6 +2694,8 @@ int do_cli_server(int argc, char **argv) /* {{{ */
 	int php_optind = 1;
 	int c;
 	const char *server_bind_address = NULL;
+	const char *server_bound_host = NULL;
+	int server_bound_port = 0;
 	extern const opt_struct OPTIONS[];
 	const char *document_root = NULL;
 #ifdef PHP_WIN32
@@ -2714,16 +2766,19 @@ int do_cli_server(int argc, char **argv) /* {{{ */
 		router = argv[php_optind];
 	}
 
-	if (FAILURE == php_cli_server_ctor(&server, server_bind_address, document_root, router)) {
+	if (FAILURE == php_cli_server_ctor(&server, server_bind_address, document_root, router,
+										&server_bound_host, &server_bound_port)) {
 		return 1;
 	}
 	sapi_module.phpinfo_as_text = 0;
 
 	{
+		zend_bool ipv6 = strchr(server_bound_host, ':');
 		php_cli_server_logf(
 			PHP_CLI_SERVER_LOG_PROCESS,
-			"PHP %s Development Server (http://%s) started",
-			PHP_VERSION, server_bind_address);
+			"PHP %s Development Server (http://%s%s%s:%d) started",
+			PHP_VERSION, ipv6 ? "[" : "", server_bound_host,
+			ipv6 ? "]" : "", server_bound_port);
 	}
 
 #if defined(SIGINT)