php_stream_cast() seeks whereas php_stream_can_cast() does not

Author: Girgias

ext/posix/posix.c

@@ -426,10 +426,11 @@ static int php_posix_stream_get_fd(zval *zfp, zend_long *fd) /* {{{ */
 	if (stream == NULL) {
 		return 0;
 	}
-	if (
-		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)&fd, 0) == FAILURE &&
-		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)&fd, 0) == FAILURE
-	) {
+	if (php_stream_can_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)fd, 0);
+	} else if (php_stream_can_cast(stream, PHP_STREAM_AS_FD) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)fd, 0);
+	} else {
 		php_error_docref(NULL, E_WARNING, "Could not use stream of type '%s'",
 				stream->ops->label);
 		return 0;

ext/posix/tests/posix_isatty_stream_lose_data.phpt

@@ -29,6 +29,8 @@ fclose($handle);
 http_server_kill($pid);
 ?>
 --EXPECTF--
+Warning: posix_isatty(): %d bytes of buffered data lost during stream conversion! in %s on line %d
+
 Warning: posix_isatty(): %d bytes of buffered data lost during stream conversion! in %s on line %d
 bool(false)
 string(4) "Body"

ext/posix/tests/posix_ttyname_stream_lose_data.phpt

@@ -29,6 +29,8 @@ fclose($handle);
 http_server_kill($pid);
 ?>
 --EXPECTF--
+Warning: posix_ttyname(): %d bytes of buffered data lost during stream conversion! in %s on line %d
+
 Warning: posix_ttyname(): %d bytes of buffered data lost during stream conversion! in %s on line %d
 bool(false)
 string(4) "Body"

ext/standard/streamsfuncs.c

@@ -1637,10 +1637,11 @@ PHP_FUNCTION(stream_isatty)
 
 	php_stream_from_zval(stream, zsrc);
 
-	if (
-		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)&fileno, 0) == FAILURE &&
-		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)&fileno, 0) == FAILURE
-	) {
+	if (php_stream_can_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)&fileno, 0);
+	} else if (php_stream_can_cast(stream, PHP_STREAM_AS_FD) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)&fileno, 0);
+	} else {
 		RETURN_FALSE;
 	}
 
@@ -1677,10 +1678,12 @@ PHP_FUNCTION(sapi_windows_vt100_support)
 
 	php_stream_from_zval(stream, zsrc);
 
-	if (
-		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)&fileno, 0) == FAILURE &&
-		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)&fileno, 0) == FAILURE
-	) {
+
+	if (php_stream_can_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD_FOR_SELECT, (void*)&fileno, 0);
+	} else if (php_stream_can_cast(stream, PHP_STREAM_AS_FD) == SUCCESS) {
+		php_stream_cast(stream, PHP_STREAM_AS_FD, (void*)&fileno, 0);
+	} else {
 		if (!enable_is_null) {
 			php_error_docref(
 				NULL,

tests/output/DummyStreamWrapper.inc

@@ -27,6 +27,7 @@ class DummyStreamWrapper
 
     public function stream_seek(int $offset, int $whence = SEEK_SET): bool
     {
+        var_dump('stream_seek!');
         return true;
     }
 

tests/output/sapi_windows_vt100_support_stream_lose_data.phpt

@@ -30,6 +30,8 @@ fclose($handle);
 http_server_kill($pid);
 ?>
 --EXPECTF--
+Warning: sapi_windows_vt100_support(): %d bytes of buffered data lost during stream conversion! in %s on line %d
+
 Warning: sapi_windows_vt100_support(): %d bytes of buffered data lost during stream conversion! in %s on line %d
 bool(false)
 string(4) "Body"

tests/output/stream_isatty_stream_lose_data.phpt

@@ -28,6 +28,8 @@ fclose($handle);
 http_server_kill($pid);
 ?>
 --EXPECTF--
+Warning: stream_isatty(): %d bytes of buffered data lost during stream conversion! in %s on line %d
+
 Warning: stream_isatty(): %d bytes of buffered data lost during stream conversion! in %s on line %d
 bool(false)
 string(4) "Body"