Review remarks

Author: nielsdos

ext/dom/tests/modern/html/encoding/HTMLDocument_createFromFile_override_encoding.phpt

@@ -11,10 +11,12 @@ try {
     echo $e->getMessage(), "\n";
 }
 
+// The override encoding matches with the document encoding attribute
 $dom = DOM\HTMLDocument::createFromFile(__DIR__ . '/gb18030_without_charset.html', overrideEncoding: 'GB18030');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);
 
+// The override encoding mismatches with the document encoding attribute
 $dom = DOM\HTMLDocument::createFromFile(__DIR__ . '/fallback_encoding.html', overrideEncoding: 'Windows-1252');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);

ext/dom/tests/modern/html/encoding/HTMLDocument_createFromString_override_encoding.phpt

@@ -11,10 +11,12 @@ try {
     echo $e->getMessage(), "\n";
 }
 
+// The override encoding matches with the document encoding attribute
 $dom = DOM\HTMLDocument::createFromString(file_get_contents(__DIR__ . '/gb18030_without_charset.html'), overrideEncoding: 'GB18030');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);
 
+// The override encoding mismatches with the document encoding attribute
 $dom = DOM\HTMLDocument::createFromString(file_get_contents(__DIR__ . '/fallback_encoding.html'), overrideEncoding: 'Windows-1252');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);

ext/dom/tests/modern/html/serializer/HTMLDocument_serialize_doctype.phpt

@@ -18,7 +18,7 @@ HTML, LIBXML_NOERROR);
 echo "--- XML encoding ---\n";
 echo $dom->saveXML();
 echo "--- HTML encoding ---\n";
-// We don't expec to see the public ID and the system ID because the serialization algorithm doesn't serialize those
+// We don't expect to see the public ID and the system ID because the serialization algorithm doesn't serialize those
 echo $dom->saveHTML();
 
 ?>

ext/dom/tests/modern/xml/XMLDocument_createFromFile_override_encoding.phpt

@@ -11,10 +11,12 @@ try {
     echo $e->getMessage(), "\n";
 }
 
+// The override encoding matches with the document encoding attribute
 $dom = DOM\XMLDocument::createFromFile(__DIR__ . '/dummy.xml', overrideEncoding: 'UTF-8');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);
 
+// The override encoding mismatches with the document encoding attribute
 $dom = DOM\XMLDocument::createFromFile(__DIR__ . '/dummy.xml', overrideEncoding: 'Windows-1252');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);

ext/dom/tests/modern/xml/XMLDocument_createFromString_override_encoding.phpt

@@ -11,10 +11,12 @@ try {
     echo $e->getMessage(), "\n";
 }
 
+// The override encoding matches with the document encoding attribute
 $dom = DOM\XMLDocument::createFromString(file_get_contents(__DIR__ . '/dummy.xml'), overrideEncoding: 'UTF-8');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);
 
+// The override encoding mismatches with the document encoding attribute
 $dom = DOM\XMLDocument::createFromString(file_get_contents(__DIR__ . '/dummy.xml'), overrideEncoding: 'Windows-1252');
 var_dump($dom->documentElement->lastChild->textContent);
 var_dump($dom->encoding);

ext/dom/tests/modern/xml/XMLDocument_fromString_03.phpt

@@ -16,9 +16,23 @@ try {
 }
 
 foreach ($flags as $flag) {
-    DOM\XMLDocument::createFromString('<?xml version="1.0"?><container/>', $flag);
+    var_dump(DOM\XMLDocument::createFromString('<?xml version="1.0"?><container/>', $flag) instanceof DOM\XMLDocument);
 }
 
 ?>
 --EXPECT--
-DOM\XMLDocument::createFromString(): Argument #2 ($options) contains invalid flags (allowed flags: LIBXML_NOENT, LIBXML_DTDLOAD, LIBXML_DTDATTR, LIBXML_DTDVALID, LIBXML_NOERROR, LIBXML_NOWARNING, LIBXML_NOBLANKS, LIBXML_XINCLUDE, LIBXML_NSCLEAN, LIBXML_NOCDATA, LIBXML_NONET, LIBXML_PEDANTIC, LIBXML_COMPACT, LIBXML_PARSEHUGE, LIBXML_BIGLINES)
+DOM\XMLDocument::createFromString(): Argument #2 ($options) contains invalid flags (allowed flags: LIBXML_NOENT, LIBXML_DTDLOAD, LIBXML_DTDATTR, LIBXML_DTDVALID, LIBXML_NOERROR, LIBXML_NOWARNING, LIBXML_NOBLANKS, LIBXML_XINCLUDE, LIBXML_NSCLEAN, LIBXML_NOCDATA, LIBXML_NONET, LIBXML_PEDANTIC, LIBXML_COMPACT, LIBXML_PARSEHUGE, LIBXML_BIGLINES)bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)
+bool(true)