Fixed a signed / unsigned issue.

Moriyoshi Koizumi · Moriyoshi Koizumi · commit f73f94f25838 · 2003-02-24T16:29:00.000Z
# imagine the case like "\\\xfe" where walk[1] takes a value that is greater
# than 127 in integer...
diff --git a/ext/ereg/ereg.c b/ext/ereg/ereg.c
@@ -324,7 +324,7 @@ PHPAPI char *php_reg_replace(const char *pattern, const char *replace, const cha
 			new_l = strlen(buf) + subs[0].rm_so; /* part before the match */
 			walk = replace;
 			while (*walk) {
-				if ('\\' == *walk && isdigit(walk[1]) && walk[1] - '0' <= ((char) re.re_nsub)) {
+				if ('\\' == *walk && isdigit(walk[1]) && ((unsigned char)walk[1]) - '0' <= re.re_nsub) {
 					if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo > -1) {
 						new_l += subs[walk[1] - '0'].rm_eo - subs[walk[1] - '0'].rm_so;
 					}    
diff --git a/ext/standard/reg.c b/ext/standard/reg.c
@@ -324,7 +324,7 @@ PHPAPI char *php_reg_replace(const char *pattern, const char *replace, const cha
 			new_l = strlen(buf) + subs[0].rm_so; /* part before the match */
 			walk = replace;
 			while (*walk) {
-				if ('\\' == *walk && isdigit(walk[1]) && walk[1] - '0' <= ((char) re.re_nsub)) {
+				if ('\\' == *walk && isdigit(walk[1]) && ((unsigned char)walk[1]) - '0' <= re.re_nsub) {
 					if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo > -1) {
 						new_l += subs[walk[1] - '0'].rm_eo - subs[walk[1] - '0'].rm_so;
 					}    

Original file line number	Diff line number	Diff line change
`@@ -324,7 +324,7 @@ PHPAPI char php_reg_replace(const char pattern, const char *replace, const cha`
`324`	`324`	`new_l = strlen(buf) + subs[0].rm_so; /* part before the match */`
`325`	`325`	`walk = replace;`
`326`	`326`	`while (*walk) {`
`327`		`- if ('\\' == *walk && isdigit(walk[1]) && walk[1] - '0' <= ((char) re.re_nsub)) {`
	`327`	`+ if ('\\' == *walk && isdigit(walk[1]) && ((unsigned char)walk[1]) - '0' <= re.re_nsub) {`
`328`	`328`	`if (subs[walk[1] - '0'].rm_so > -1 && subs[walk[1] - '0'].rm_eo > -1) {`
`329`	`329`	`new_l += subs[walk[1] - '0'].rm_eo - subs[walk[1] - '0'].rm_so;`
`330`	`330`	`}`