Skip to content

Commit f3b4c05

Browse files
committed
Merge branch 'PHP-5.5' into PHP-5.6
* PHP-5.5: updated NEWS Fixed bug #55541 errors spawn MessageBox, which blocks test automation
2 parents cd68c4b + 13aaba4 commit f3b4c05

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Zend/zend_ini_parser.y

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@
2929
#include "zend_ini_scanner.h"
3030
#include "zend_extensions.h"
3131

32+
#ifdef PHP_WIN32
33+
#include "win32/syslog.h"
34+
#endif
35+
3236
#define YYERROR_VERBOSE
3337
#define YYSTYPE zval
3438

@@ -179,10 +183,9 @@ static void ini_error(char *msg)
179183

180184
if (CG(ini_parser_unbuffered_errors)) {
181185
#ifdef PHP_WIN32
182-
MessageBox(NULL, error_buf, "PHP Error", MB_OK|MB_TOPMOST|0x00200000L);
183-
#else
184-
fprintf(stderr, "PHP: %s", error_buf);
186+
syslog(LOG_ALERT, "PHP: %s (%s)", error_buf, GetCommandLine());
185187
#endif
188+
fprintf(stderr, "PHP: %s", error_buf);
186189
} else {
187190
zend_error(E_WARNING, "%s", error_buf);
188191
}

main/main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,8 +1142,8 @@ static void php_error_cb(int type, const char *error_filename, const uint error_
11421142
if (!module_initialized || PG(log_errors)) {
11431143
char *log_buffer;
11441144
#ifdef PHP_WIN32
1145-
if ((type == E_CORE_ERROR || type == E_CORE_WARNING) && PG(display_startup_errors)) {
1146-
MessageBox(NULL, buffer, error_type_str, MB_OK|ZEND_SERVICE_MB_STYLE);
1145+
if (type == E_CORE_ERROR || type == E_CORE_WARNING) {
1146+
syslog(LOG_ALERT, "PHP %s: %s (%s)", error_type_str, buffer, GetCommandLine());
11471147
}
11481148
#endif
11491149
spprintf(&log_buffer, 0, "PHP %s: %s in %s on line %d", error_type_str, buffer, error_filename, error_lineno);

0 commit comments

Comments
 (0)