Don't return bool from Phar::offsetUnset()

This violates the ArrayAccess interface. Use offsetExists() to
check if an entry exists.

Author: nikic

UPGRADING

@@ -147,6 +147,10 @@ PHP 8.1 UPGRADE NOTES
     default connection is deprecated.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_1
 
+- Phar:
+  . To comply with the ArrayAccess interface, Phar::offsetUnset() and
+    PharData::offsetUnset() no longer return a boolean.
+
 - PSpell:
   . The PSpell functions now accept and return, respectively, PSpell\Dictionary objects
     instead of "pspell" resources. Return value checks using is_resource()

ext/phar/phar_object.c

@@ -3759,11 +3759,7 @@ PHP_METHOD(Phar, offsetUnset)
 				zend_throw_exception_ex(phar_ce_PharException, 0, "%s", error);
 				efree(error);
 			}
-
-			RETURN_TRUE;
 		}
-	} else {
-		RETURN_FALSE;
 	}
 }
 /* }}} */

ext/phar/phar_object.stub.php

@@ -119,7 +119,7 @@ public function offsetSet($localName, $value): void {}
      * @param string $localName
      * @tentative-return-type
      */
-    public function offsetUnset($localName): bool {}
+    public function offsetUnset($localName): void {}
 
     /** @tentative-return-type */
     public function setAlias(string $alias): bool {}
@@ -386,7 +386,7 @@ public function offsetSet($localName, $value): void {}
      * @tentative-return-type
      * @implementation-alias Phar::offsetUnset
      */
-    public function offsetUnset($localName): bool {}
+    public function offsetUnset($localName): void {}
 
     /**
      * @tentative-return-type

ext/phar/phar_object_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: ac04a4161a11d054922cb04787f81f5661203e3e */
+ * Stub hash: ddb04eb0a40f19ad06cb351e545895a8dd58fece */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Phar___construct, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, filename, IS_STRING, 0)
@@ -128,7 +128,9 @@ ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Phar_offsetSet,
 	ZEND_ARG_INFO(0, value)
 ZEND_END_ARG_INFO()
 
-#define arginfo_class_Phar_offsetUnset arginfo_class_Phar_offsetExists
+ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Phar_offsetUnset, 0, 1, IS_VOID, 0)
+	ZEND_ARG_INFO(0, localName)
+ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Phar_setAlias, 0, 1, _IS_BOOL, 0)
 	ZEND_ARG_TYPE_INFO(0, alias, IS_STRING, 0)
@@ -297,7 +299,7 @@ ZEND_END_ARG_INFO()
 
 #define arginfo_class_PharData_offsetSet arginfo_class_Phar_offsetSet
 
-#define arginfo_class_PharData_offsetUnset arginfo_class_Phar_offsetExists
+#define arginfo_class_PharData_offsetUnset arginfo_class_Phar_offsetUnset
 
 #define arginfo_class_PharData_setAlias arginfo_class_Phar_setAlias