Skip to content

Commit ed097e3

Browse files
nielsdosGirgias
authored andcommitted
No need for the double name pointer
1 parent 47c277b commit ed097e3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ext/simplexml/simplexml.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ static xmlNodePtr sxe_find_element_by_name(php_sxe_object *sxe, xmlNodePtr node,
160160
return NULL;
161161
} /* }}} */
162162

163-
static xmlNodePtr sxe_get_element_by_name(php_sxe_object *sxe, xmlNodePtr node, char **name, SXE_ITER *type) /* {{{ */
163+
static xmlNodePtr sxe_get_element_by_name(php_sxe_object *sxe, xmlNodePtr node, char *name, SXE_ITER *type) /* {{{ */
164164
{
165165
int orgtype;
166166
xmlNodePtr orgnode = node;
@@ -186,7 +186,7 @@ static xmlNodePtr sxe_get_element_by_name(php_sxe_object *sxe, xmlNodePtr node,
186186
while (node) {
187187
SKIP_TEXT(node)
188188
if (node->type == XML_ELEMENT_NODE && match_ns(sxe, node, sxe->iter.nsprefix, sxe->iter.isprefix)) {
189-
if (xmlStrEqual(node->name, (xmlChar *)*name)) {
189+
if (xmlStrEqual(node->name, (xmlChar *)name)) {
190190
*type = SXE_ITER_ELEMENT;
191191
return orgnode;
192192
}
@@ -634,7 +634,7 @@ static zval *sxe_property_get_adr(zend_object *object, zend_string *zname, int f
634634
sxe = php_sxe_fetch_object(object);
635635
GET_NODE(sxe, node);
636636
name = ZSTR_VAL(zname);
637-
node = sxe_get_element_by_name(sxe, node, &name, &type);
637+
node = sxe_get_element_by_name(sxe, node, name, &type);
638638
if (node) {
639639
return NULL;
640640
}

0 commit comments

Comments
 (0)