Skip to content

Commit ed0938f

Browse files
committed
Add deprecation data for Zip
1 parent 40a07f9 commit ed0938f

16 files changed

+232
-137
lines changed

ext/zip/php_zip.stub.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,63 +5,63 @@
55
/**
66
* @return resource|int|false
77
*/
8-
#[\Deprecated]
8+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::open() instead')]
99
function zip_open(string $filename) {}
1010

1111
/**
1212
* @param resource $zip
1313
*/
14-
#[\Deprecated]
14+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::close() instead')]
1515
function zip_close($zip): void {}
1616

1717
/**
1818
* @param resource $zip
1919
* @return resource|false
2020
*/
21-
#[\Deprecated]
21+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::statIndex() instead')]
2222
function zip_read($zip) {}
2323

2424
/**
2525
* @param resource $zip_dp
2626
* @param resource $zip_entry
2727
*/
28-
#[\Deprecated]
28+
#[\Deprecated(since: '8.0')]
2929
function zip_entry_open($zip_dp, $zip_entry, string $mode = "rb"): bool {}
3030

3131
/**
3232
* @param resource $zip_entry
3333
*/
34-
#[\Deprecated]
34+
#[\Deprecated(since: '8.0')]
3535
function zip_entry_close($zip_entry): bool {}
3636

3737
/**
3838
* @param resource $zip_entry
3939
*/
40-
#[\Deprecated]
40+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::getFromIndex() instead')]
4141
function zip_entry_read($zip_entry, int $len = 1024): string|false {}
4242

4343
/**
4444
* @param resource $zip_entry
4545
*/
46-
#[\Deprecated]
46+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::statIndex() instead')]
4747
function zip_entry_name($zip_entry): string|false {}
4848

4949
/**
5050
* @param resource $zip_entry
5151
*/
52-
#[\Deprecated]
52+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::statIndex() instead')]
5353
function zip_entry_compressedsize($zip_entry): int|false {}
5454

5555
/**
5656
* @param resource $zip_entry
5757
*/
58-
#[\Deprecated]
58+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::statIndex() instead')]
5959
function zip_entry_filesize($zip_entry): int|false {}
6060

6161
/**
6262
* @param resource $zip_entry
6363
*/
64-
#[\Deprecated]
64+
#[\Deprecated(since: '8.0', message: 'use ZipArchive::statIndex() instead')]
6565
function zip_entry_compressionmethod($zip_entry): string|false {}
6666

6767
class ZipArchive implements Countable
@@ -110,7 +110,7 @@ class ZipArchive implements Countable
110110
/**
111111
* @cvalue ZIP_FL_RECOMPRESS
112112
*/
113-
#[\Deprecated]
113+
#[\Deprecated(since: '8.3')]
114114
public const int FL_RECOMPRESS = UNKNOWN;
115115
#endif
116116
/**

ext/zip/php_zip_arginfo.h

Lines changed: 116 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

ext/zip/tests/bug7214.phpt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ if (strlen($contents) == zip_entry_filesize($entry)) {
1717

1818
?>
1919
--EXPECTF--
20-
Deprecated: Function zip_open() is deprecated in %s on line %d
20+
Deprecated: Function zip_open() is deprecated since 8.0, use ZipArchive::open() instead in %s on line %d
2121

22-
Deprecated: Function zip_read() is deprecated in %s on line %d
22+
Deprecated: Function zip_read() is deprecated since 8.0, use ZipArchive::statIndex() instead in %s on line %d
2323

24-
Deprecated: Function zip_entry_filesize() is deprecated in %s on line %d
24+
Deprecated: Function zip_entry_filesize() is deprecated since 8.0, use ZipArchive::statIndex() instead in %s on line %d
2525

26-
Deprecated: Function zip_entry_read() is deprecated in %s on line %d
26+
Deprecated: Function zip_entry_read() is deprecated since 8.0, use ZipArchive::getFromIndex() instead in %s on line %d
2727

28-
Deprecated: Function zip_entry_filesize() is deprecated in %s on line %d
28+
Deprecated: Function zip_entry_filesize() is deprecated since 8.0, use ZipArchive::statIndex() instead in %s on line %d
2929
Ok

ext/zip/tests/doubleclose.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ Done
3838
--EXPECTF--
3939
Procedural
4040

41-
Deprecated: Function zip_open() is deprecated in %s on line %d
41+
Deprecated: Function zip_open() is deprecated since 8.0, use ZipArchive::open() instead in %s on line %d
4242

43-
Deprecated: Function zip_close() is deprecated in %s on line %d
43+
Deprecated: Function zip_close() is deprecated since 8.0, use ZipArchive::close() instead in %s on line %d
4444
NULL
4545

46-
Deprecated: Function zip_close() is deprecated in %s on line %d
46+
Deprecated: Function zip_close() is deprecated since 8.0, use ZipArchive::close() instead in %s on line %d
4747
zip_close(): supplied resource is not a valid Zip Directory resource
4848
Object
4949
bool(true)

0 commit comments

Comments
 (0)