Remove redundant check in pdo_raise_impl_error (#13851)

nielsdos · web-flow · commit eaaf175bbbf5 · 2024-03-31T16:16:17.000+02:00
`dbh` is always non-NULL because it is dereferenced at the start of the
function.
diff --git a/ext/pdo/pdo_dbh.c b/ext/pdo/pdo_dbh.c
@@ -98,7 +98,7 @@ void pdo_raise_impl_error(pdo_dbh_t *dbh, pdo_stmt_t *stmt, pdo_error_type sqlst
 		spprintf(&message, 0, "SQLSTATE[%s]: %s", *pdo_err, msg);
 	}
 
-	if (dbh && dbh->error_mode != PDO_ERRMODE_EXCEPTION) {
+	if (dbh->error_mode != PDO_ERRMODE_EXCEPTION) {
 		php_error_docref(NULL, E_WARNING, "%s", message);
 	} else {
 		zval ex, info;

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ void pdo_raise_impl_error(pdo_dbh_t dbh, pdo_stmt_t stmt, pdo_error_type sqlst`
`98`	`98`	`spprintf(&message, 0, "SQLSTATE[%s]: %s", *pdo_err, msg);`
`99`	`99`	`}`
`100`	`100`
`101`		`- if (dbh && dbh->error_mode != PDO_ERRMODE_EXCEPTION) {`
	`101`	`+ if (dbh->error_mode != PDO_ERRMODE_EXCEPTION) {`
`102`	`102`	`php_error_docref(NULL, E_WARNING, "%s", message);`
`103`	`103`	`} else {`
`104`	`104`	`zval ex, info;`