Remove mysqli_driver::$reconnect property

Author: kamil-tekiela

ext/mysqli/mysqli.c

@@ -461,7 +461,6 @@ static PHP_GINIT_FUNCTION(mysqli)
 	mysqli_globals->default_user = NULL;
 	mysqli_globals->default_pw = NULL;
 	mysqli_globals->default_socket = NULL;
-	mysqli_globals->reconnect = 0;
 	mysqli_globals->report_mode = MYSQLI_REPORT_ERROR|MYSQLI_REPORT_STRICT;;
 	mysqli_globals->allow_local_infile = 0;
 	mysqli_globals->local_infile_directory = NULL;

ext/mysqli/mysqli.stub.php

@@ -13,8 +13,6 @@ final class mysqli_driver
     /** @readonly */
     public int $driver_version;
 
-    public bool $reconnect = false;
-
     public int $report_mode = 0;
 }
 

ext/mysqli/mysqli_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: c6cbd75fdef85706a369d1f06b814c73436f8ae6 */
+ * Stub hash: 3678d3f6a5bd74a521eadae8db1b9835ef83c423 */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_mysqli_affected_rows, 0, 1, MAY_BE_LONG|MAY_BE_STRING)
 	ZEND_ARG_OBJ_INFO(0, mysql, mysqli, 0)
@@ -1051,12 +1051,6 @@ static zend_class_entry *register_class_mysqli_driver(void)
 	zend_declare_typed_property(class_entry, property_driver_version_name, &property_driver_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
 	zend_string_release(property_driver_version_name);
 
-	zval property_reconnect_default_value;
-	ZVAL_BOOL(&property_reconnect_default_value, 0);
-	zend_string *property_reconnect_name = zend_string_init("reconnect", sizeof("reconnect") - 1, 1);
-	zend_declare_typed_property(class_entry, property_reconnect_name, &property_reconnect_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_BOOL));
-	zend_string_release(property_reconnect_name);
-
 	zval property_report_mode_default_value;
 	ZVAL_LONG(&property_report_mode_default_value, 0);
 	zend_string *property_report_mode_name = zend_string_init("report_mode", sizeof("report_mode") - 1, 1);

ext/mysqli/mysqli_driver.c

@@ -27,23 +27,6 @@
 #include "zend_exceptions.h"
 
 
-/* {{{ property driver_reconnect_read */
-static int driver_reconnect_read(mysqli_object *obj, zval *retval, bool quiet)
-{
-	ZVAL_BOOL(retval, MyG(reconnect));
-	return SUCCESS;
-}
-/* }}} */
-
-/* {{{ property driver_reconnect_write */
-static int driver_reconnect_write(mysqli_object *obj, zval *value)
-{
-	ZEND_ASSERT(Z_TYPE_P(value) == IS_TRUE || Z_TYPE_P(value) == IS_FALSE);
-	MyG(reconnect) = Z_TYPE_P(value) == IS_TRUE;
-	return SUCCESS;
-}
-/* }}} */
-
 /* {{{ property driver_report_read */
 static int driver_report_read(mysqli_object *obj, zval *retval, bool quiet)
 {
@@ -93,7 +76,6 @@ const mysqli_property_entry mysqli_driver_property_entries[] = {
 	{"client_info", sizeof("client_info") - 1, driver_client_info_read, NULL},
 	{"client_version", sizeof("client_version") - 1, driver_client_version_read, NULL},
 	{"driver_version", sizeof("driver_version") - 1, driver_driver_version_read, NULL},
-	{"reconnect", sizeof("reconnect") - 1, driver_reconnect_read, driver_reconnect_write},
 	{"report_mode", sizeof("report_mode") - 1, driver_report_read, driver_report_write},
 	{NULL, 0, NULL, NULL}
 };

ext/mysqli/php_mysqli_structs.h

@@ -248,7 +248,6 @@ ZEND_BEGIN_MODULE_GLOBALS(mysqli)
 	char				*default_user;
 	char				*default_pw;
 	char				*default_socket;
-	zend_long			reconnect;
 	zend_long			allow_local_infile;
 	char				*local_infile_directory;
 	zend_long			error_no;