Remove always-false condition from substr_replace()

nielsdos · nielsdos · commit e78966386b96 · 2023-12-12T16:43:43.000Z
l &lt; 0 is checked before and set to a different value.
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -2171,7 +2171,7 @@ PHP_FUNCTION(substr_replace)
 			}
 		}
 
-		if ((size_t)l > ZSTR_LEN(str) || (l < 0 && (size_t)(-l) > ZSTR_LEN(str))) {
+		if ((size_t)l > ZSTR_LEN(str)) {
 			l = ZSTR_LEN(str);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -2171,7 +2171,7 @@ PHP_FUNCTION(substr_replace)`
`2171`	`2171`	`}`
`2172`	`2172`	`}`
`2173`	`2173`
`2174`		`- if ((size_t)l > ZSTR_LEN(str) \|\| (l < 0 && (size_t)(-l) > ZSTR_LEN(str))) {`
	`2174`	`+ if ((size_t)l > ZSTR_LEN(str)) {`
`2175`	`2175`	`l = ZSTR_LEN(str);`
`2176`	`2176`	`}`
`2177`	`2177`