Increase precedence of pipe operator.

Author: Crell

Zend/tests/pipe_operator/precedence_addition.phpt

@@ -9,6 +9,7 @@ function _test1(int $a): int {
 
 $bad_func = null;
 
+// This should add 5+2 first, then pipe that to _test1.
 $res1 = 5 + 2 |>  '_test1';
 
 var_dump($res1);

Zend/tests/pipe_operator/precedence_coalesce.phpt

@@ -1,17 +1,17 @@
 --TEST--
-Pipe binds lower than coalesce
+Pipe binds higher than coalesce
 --FILE--
 <?php
 
-function _test1(int $a): int {
-    return $a * 2;
+function get_username(int $a): string {
+    return (string)$a;
 }
 
-$bad_func = null;
+$user = 5
+     |> get_username(...)
+     ?? 'default';
 
-$res1 = 5 |> $bad_func ?? '_test1';
-
-var_dump($res1);
+var_dump($user);
 ?>
 --EXPECT--
-int(10)
+string(1) "5"

Zend/tests/pipe_operator/precedence_comparison.phpt

@@ -7,21 +7,10 @@ function _test1(int $a): int {
     return $a * 2;
 }
 
-$res1 = (5 |> _test1(...)) == 10 ;
+// The pipe should run before the comparison.
+$res1 = 5 |> _test1(...) == 10 ;
 var_dump($res1);
 
-// This will error without the parens,
-// as it will try to compare a closure to an int first.
-try {
-    $res1 = 5 |> _test1(...) == 10 ;
-}
-catch (Throwable $e) {
-    echo $e::class, ": ", $e->getMessage(), PHP_EOL;
-}
-
 ?>
 --EXPECTF--
 bool(true)
-
-Notice: Object of class Closure could not be converted to int in %s line %d
-Error: Value of type bool is not callable

Zend/tests/pipe_operator/precedence_ternary.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Pipe binds lower than ternary
+Pipe binds higher than ternary
 --FILE--
 <?php
 
@@ -15,19 +15,14 @@ function _test3(int $a): int {
     return $a * 100;
 }
 
-// $config is null, so the second function gets used.
-$config = null;
-$res1 = 5 |> $config ? _test1(...) : _test2(...);
-var_dump($res1);
+function is_odd(int $a): bool {
+    return (bool)($a % 2);
+}
 
-// $config is truthy, so the ternary binds first
-// and evaluates to the first function.
-$config = _test3(...);
-$res2 = 5 |> $config ? _test1(...) : _test2(...);
-var_dump($res2);
+$res1 = 5 |> is_odd(...) ? 'odd' : 'even';
+var_dump($res1);
 
-// Binding the ternary first doesn't make logical sense,
-// so the pipe runs first in this case.
+// The pipe binds first, resulting in bool ? int : string, which is well-understood.
 $x = true;
 $y = 'beep';
 $z = 'default';
@@ -37,6 +32,5 @@ var_dump($ret3);
 
 ?>
 --EXPECT--
-int(10)
-int(6)
+string(3) "odd"
 int(4)

Zend/zend_language_parser.y

@@ -62,7 +62,6 @@ static YYSIZE_T zend_yytnamerr(char*, const char*);
 %precedence T_DOUBLE_ARROW
 %precedence T_YIELD_FROM
 %precedence '=' T_PLUS_EQUAL T_MINUS_EQUAL T_MUL_EQUAL T_DIV_EQUAL T_CONCAT_EQUAL T_MOD_EQUAL T_AND_EQUAL T_OR_EQUAL T_XOR_EQUAL T_SL_EQUAL T_SR_EQUAL T_POW_EQUAL T_COALESCE_EQUAL
-%left T_PIPE
 %left '?' ':'
 %right T_COALESCE
 %left T_BOOLEAN_OR
@@ -72,6 +71,7 @@ static YYSIZE_T zend_yytnamerr(char*, const char*);
 %left T_AMPERSAND_NOT_FOLLOWED_BY_VAR_OR_VARARG T_AMPERSAND_FOLLOWED_BY_VAR_OR_VARARG
 %nonassoc T_IS_EQUAL T_IS_NOT_EQUAL T_IS_IDENTICAL T_IS_NOT_IDENTICAL T_SPACESHIP
 %nonassoc '<' T_IS_SMALLER_OR_EQUAL '>' T_IS_GREATER_OR_EQUAL
+%left T_PIPE
 %left '.'
 %left T_SL T_SR
 %left '+' '-'