Skip to content

Commit e6cc1e2

Browse files
committed
Improve and optimize variable second move after if statement
1 parent 4472ef1 commit e6cc1e2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

ext/mbstring/mbstring.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2969,16 +2969,15 @@ static void php_mb_ulcfirst(INTERNAL_FUNCTION_PARAMETERS, php_case_mode mode)
29692969
}
29702970

29712971
zend_string *first = mb_get_substr(str, 0, 1, enc);
2972-
zend_string *second = mb_get_substr(str, 1, MBFL_SUBSTR_UNTIL_END, enc);
29732972
zend_string *head = mbstring_convert_case(mode, ZSTR_VAL(first), ZSTR_LEN(first), enc);
29742973

29752974
if (zend_string_equals(first, head)) {
29762975
zend_string_release_ex(first, false);
29772976
zend_string_release_ex(head, false);
2978-
zend_string_release_ex(second, false);
29792977
RETURN_STR(zend_string_copy(str));
29802978
}
29812979

2980+
zend_string *second = mb_get_substr(str, 1, MBFL_SUBSTR_UNTIL_END, enc);
29822981
zend_string_release_ex(first, false);
29832982
zend_string *retval = zend_string_concat2(ZSTR_VAL(head), ZSTR_LEN(head), ZSTR_VAL(second), ZSTR_LEN(second));
29842983
zend_string_release_ex(head, false);

0 commit comments

Comments
 (0)