Skip to content

Commit e550ff4

Browse files
committed
Update array parameter names for named parameter DX.
Change $sort_flags to $flags. Remove $array1 from array_map() Rename $cmp_function to $comparison in user-sorting functions. Change $funcname to the more standard $callback. Remove $array1 from array_replace*(). Simplify array_keys() arguments to be more usefully named. Change array_diff*() and array_intersect*() to have be more logically named parameters. Standardize array_key_exists() on $array, which the docs already use. Switch array_fill*() arguments to be more self-descriptive. Change $vars to $values in array_unshift(), to be more consistent and descriptive. Rename $userdata to $arguments, since that is how it will be used. Change array_replace() to use $substitutions instead. Update more tests. Standardize callback name to $callback. Update tests. Use plurals for variadics. Update another test. Update reflection tests. Fix another test. Use $replacements for substitution values. Update tests.
1 parent 79efbb1 commit e550ff4

12 files changed

+34
-3544
lines changed

Zend/tests/bug31720.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ try {
1212
?>
1313
--EXPECTF--
1414
Warning: Undefined variable $nonesuchvar in %s on line %d
15-
array_walk(): Argument #2 ($funcname) must be a valid callback, first array member is not a valid class name or object
15+
array_walk(): Argument #2 ($callback) must be a valid callback, first array member is not a valid class name or object

Zend/tests/named_params/missing_param.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ try {
2525
}
2626

2727
// This works fine, as search_value is explicitly specified.
28-
var_dump(array_keys([41, 42], search_value: 42, strict: true));
28+
var_dump(array_keys([41, 42], for_value: 42, strict: true));
2929

3030
?>
3131
--EXPECT--
3232
test(): Argument #2 ($b) not passed
3333
array_keys(): Argument #1 ($array) not passed
34-
array_keys(): Argument #2 ($search_value) must be passed explicitly, because the default value is not known
34+
array_keys(): Argument #2 ($for_value) must be passed explicitly, because the default value is not known
3535
array(1) {
3636
[0]=>
3737
int(1)

ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Name: array
5151
Is passed by reference: yes
5252
Can be passed by value: no
5353

54-
Name: sort_flags
54+
Name: flags
5555
Is passed by reference: no
5656
Can be passed by value: yes
5757

ext/spl/tests/arrayObject_asort_basic1.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ object(ArrayObject)#%d (1) {
3636
int(4)
3737
}
3838
}
39-
asort(): Argument #2 ($sort_flags) must be of type int, string given
39+
asort(): Argument #2 ($flags) must be of type int, string given
4040
object(ArrayObject)#%d (1) {
4141
["storage":"ArrayObject":private]=>
4242
array(3) {

ext/spl/tests/arrayObject_ksort_basic1.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ object(ArrayObject)#%d (1) {
3535
int(3)
3636
}
3737
}
38-
ksort(): Argument #2 ($sort_flags) must be of type int, string given
38+
ksort(): Argument #2 ($flags) must be of type int, string given
3939
object(ArrayObject)#2 (1) {
4040
["storage":"ArrayObject":private]=>
4141
array(4) {

ext/standard/basic_functions.stub.php

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ function stream_wrapper_restore(string $protocol): bool {}
5757

5858
/* array.c */
5959

60-
function array_push(array &$stack, mixed ...$args): int {}
60+
function array_push(array &$stack, mixed ...$values): int {}
6161

62-
function krsort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
62+
function krsort(array &$array, int $flags = SORT_REGULAR): bool {}
6363

64-
function ksort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
64+
function ksort(array &$array, int $flags = SORT_REGULAR): bool {}
6565

6666
/** @param Countable|array $var */
6767
function count($var, int $mode = COUNT_NORMAL): int {}
@@ -76,19 +76,19 @@ function natsort(array &$array): bool {}
7676

7777
function natcasesort(array &$array): bool {}
7878

79-
function asort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
79+
function asort(array &$array, int $flags = SORT_REGULAR): bool {}
8080

81-
function arsort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
81+
function arsort(array &$array, int $flags = SORT_REGULAR): bool {}
8282

83-
function sort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
83+
function sort(array &$array, int $flags = SORT_REGULAR): bool {}
8484

85-
function rsort(array &$array, int $sort_flags = SORT_REGULAR): bool {}
85+
function rsort(array &$array, int $flags = SORT_REGULAR): bool {}
8686

87-
function usort(array &$array, callable $cmp_function): bool {}
87+
function usort(array &$array, callable $callback): bool {}
8888

89-
function uasort(array &$array, callable $cmp_function): bool {}
89+
function uasort(array &$array, callable $callback): bool {}
9090

91-
function uksort(array &$array, callable $cmp_function): bool {}
91+
function uksort(array &$array, callable $callback): bool {}
9292

9393
function end(array|object &$arg): mixed {}
9494

@@ -109,9 +109,9 @@ function min(mixed $arg, mixed ...$args): mixed {}
109109

110110
function max(mixed $arg, mixed ...$args): mixed {}
111111

112-
function array_walk(array|object &$input, callable $funcname, mixed $userdata = UNKNOWN): bool {}
112+
function array_walk(array|object &$input, callable $callback, mixed $arguments = UNKNOWN): bool {}
113113

114-
function array_walk_recursive(array|object &$input, callable $funcname, mixed $userdata = UNKNOWN): bool {}
114+
function array_walk_recursive(array|object &$input, callable $callback, mixed $arguments = UNKNOWN): bool {}
115115

116116
function in_array(mixed $needle, array $haystack, bool $strict = false): bool {}
117117

@@ -126,9 +126,9 @@ function extract(array &$array, int $extract_type = EXTR_OVERWRITE, string $pref
126126
*/
127127
function compact($var_name, ...$var_names): array {}
128128

129-
function array_fill(int $start_key, int $num, mixed $val): array {}
129+
function array_fill(int $start_key, int $count, mixed $value): array {}
130130

131-
function array_fill_keys(array $keys, mixed $val): array {}
131+
function array_fill_keys(array $keys, mixed $value): array {}
132132

133133
/**
134134
* @param string|int|float $low
@@ -142,21 +142,21 @@ function array_pop(array &$stack): mixed {}
142142

143143
function array_shift(array &$stack): mixed {}
144144

145-
function array_unshift(array &$stack, mixed ...$vars): int {}
145+
function array_unshift(array &$stack, mixed ...$values): int {}
146146

147-
function array_splice(array &$array, int $offset, ?int $length = null, mixed $replacement = []): array {}
147+
function array_splice(array &$array, int $offset, ?int $length = null, mixed $replacements = []): array {}
148148

149149
function array_slice(array $array, int $offset, ?int $length = null, bool $preserve_keys = false): array {}
150150

151151
function array_merge(array ...$arrays): array {}
152152

153153
function array_merge_recursive(array ...$arrays): array {}
154154

155-
function array_replace(array $array1, array ...$arrays): array {}
155+
function array_replace(array $array, array ...$replacements): array {}
156156

157-
function array_replace_recursive(array $array1, array ...$arrays): array {}
157+
function array_replace_recursive(array $array, array ...$replacements): array {}
158158

159-
function array_keys(array $array, mixed $search_value = UNKNOWN, bool $strict = false): array {}
159+
function array_keys(array $array, mixed $for_value = UNKNOWN, bool $strict = false): array {}
160160

161161
function array_key_first(array $array): int|string|null {}
162162

@@ -238,16 +238,16 @@ function array_reduce(array $array, callable $callback, mixed $initial = null):
238238

239239
function array_filter(array $array, ?callable $callback = null, int $use_keys = 0): array {}
240240

241-
function array_map(?callable $callback, array $array1, array ...$arrays): array {}
241+
function array_map(?callable $callback, array $array, array ...$arrays): array {}
242242

243243
/** @param string|int $key */
244-
function array_key_exists($key, array $search): bool {}
244+
function array_key_exists($key, array $array): bool {}
245245

246246
/**
247247
* @param string|int $key
248248
* @alias array_key_exists
249249
*/
250-
function key_exists($key, array $search): bool {}
250+
function key_exists($key, array $array): bool {}
251251

252252
function array_chunk(array $array, int $size, bool $preserve_keys = false): array {}
253253

0 commit comments

Comments
 (0)