Add test case for SplFileObject::fstat() when fstat() is disabled

Author: Girgias

ext/spl/spl_directory.c

@@ -2706,6 +2706,7 @@ PHP_METHOD(SplFileObject, fread)
 }
 
 /* {{{ Stat() on a filehandle */
+// TODO Don't call fstat? As it may be undefined if it is disabled via disable_functions
 PHP_METHOD(SplFileObject, fstat)
 {
 	spl_filesystem_object *intern = Z_SPLFILESYSTEM_P(ZEND_THIS);
@@ -2717,7 +2718,7 @@ PHP_METHOD(SplFileObject, fstat)
 
 	func_ptr = (zend_function *)zend_hash_str_find_ptr(EG(function_table), "fstat", sizeof("fstat") - 1);
 	if (func_ptr == NULL) {
-		zend_throw_exception_ex(spl_ce_RuntimeException, 0, "Internal error, function fstat() not found. Please report");
+		zend_throw_exception_ex(spl_ce_RuntimeException, 0, "fstat() is not defined");
 		RETURN_THROWS();
 	}
 

ext/spl/tests/SplFileObject_fstat_with_basic_fstat_disabled.phpt

@@ -0,0 +1,15 @@
+--TEST--
+SplFileObject::fstat when fstat() has been disabled.
+--INI--
+disable_functions="fstat"
+--FILE--
+<?php
+$obj = New SplFileObject(__DIR__.'/SplFileObject_testinput.csv');
+try {
+    var_dump($obj->fstat());
+} catch (\RuntimeException $e) {
+    echo $e->getMessage() . \PHP_EOL;
+}
+?>
+--EXPECT--
+fstat() is not defined