Print error code if CreateMutex() fails

cmb69 · cmb69 · commit e0e167e58122 · 2021-03-05T15:06:18.000+01:00
This issue came up recently in a bug report[1]; without the error code, users can barely guess why the function failed. [1] <https://bugs.php.net/80812> Closes GH-6745.
diff --git a/ext/opcache/shared_alloc_win32.c b/ext/opcache/shared_alloc_win32.c
@@ -80,7 +80,7 @@ void zend_shared_alloc_create_lock(void)
 {
 	memory_mutex = CreateMutex(NULL, FALSE, create_name_with_username(ACCEL_MUTEX_NAME));
 	if (!memory_mutex) {
-		zend_accel_error(ACCEL_LOG_FATAL, "Cannot create mutex");
+		zend_accel_error(ACCEL_LOG_FATAL, "Cannot create mutex (error %u)", GetLastError());
 		return;
 	}
 	ReleaseMutex(memory_mutex);

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ void zend_shared_alloc_create_lock(void)`
`80`	`80`	`{`
`81`	`81`	`memory_mutex = CreateMutex(NULL, FALSE, create_name_with_username(ACCEL_MUTEX_NAME));`
`82`	`82`	`if (!memory_mutex) {`
`83`		`- zend_accel_error(ACCEL_LOG_FATAL, "Cannot create mutex");`
	`83`	`+ zend_accel_error(ACCEL_LOG_FATAL, "Cannot create mutex (error %u)", GetLastError());`
`84`	`84`	`return;`
`85`	`85`	`}`
`86`	`86`	`ReleaseMutex(memory_mutex);`