Skip to content

Commit e0a8c7a

Browse files
committed
Remove CV limitation when determining value from type in SCCP
As far as I can determine, this is no longer a problem: We will not try to remove the defining instructions (this is only done if the value is known by SCCP itself) and we also only determine non-refcounted values in this way, so it is not a problem if the FREE is omitted.
1 parent 9e403d6 commit e0a8c7a

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

ext/opcache/Optimizer/sccp.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2164,11 +2164,6 @@ static zval *value_from_type_and_range(sccp_ctx *ctx, int var_num, zval *tmp) {
21642164
zend_ssa *ssa = ctx->scdf.ssa;
21652165
zend_ssa_var_info *info = &ssa->var_info[var_num];
21662166

2167-
if (ssa->vars[var_num].var >= ctx->scdf.op_array->last_var) {
2168-
// TODO Non-CVs may cause issues with FREEs
2169-
return NULL;
2170-
}
2171-
21722167
if (info->type & MAY_BE_UNDEF) {
21732168
return NULL;
21742169
}

0 commit comments

Comments
 (0)