Remove dead code

nielsdos · nielsdos · commit e04d37b9b746 · 2023-02-25T20:45:47.000+01:00
s is always NULL, so the check is always false.
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c
@@ -1672,7 +1672,7 @@ PHP_FUNCTION(openssl_spki_verify)
 PHP_FUNCTION(openssl_spki_export)
 {
 	size_t spkstr_len;
-	char *spkstr, * spkstr_cleaned = NULL, * s = NULL;
+	char *spkstr, * spkstr_cleaned = NULL;
 	int spkstr_cleaned_len;
 
 	EVP_PKEY *pkey = NULL;
@@ -1727,9 +1727,6 @@ PHP_FUNCTION(openssl_spki_export)
 	if (spkstr_cleaned != NULL) {
 		efree(spkstr_cleaned);
 	}
-	if (s != NULL) {
-		efree(s);
-	}
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -1672,7 +1672,7 @@ PHP_FUNCTION(openssl_spki_verify)`
`1672`	`1672`	`PHP_FUNCTION(openssl_spki_export)`
`1673`	`1673`	`{`
`1674`	`1674`	`size_t spkstr_len;`
`1675`		`- char spkstr, spkstr_cleaned = NULL, * s = NULL;`
	`1675`	`+ char spkstr, spkstr_cleaned = NULL;`
`1676`	`1676`	`int spkstr_cleaned_len;`
`1677`	`1677`
`1678`	`1678`	`EVP_PKEY *pkey = NULL;`
`@@ -1727,9 +1727,6 @@ PHP_FUNCTION(openssl_spki_export)`
`1727`	`1727`	`if (spkstr_cleaned != NULL) {`
`1728`	`1728`	`efree(spkstr_cleaned);`
`1729`	`1729`	`}`
`1730`		`- if (s != NULL) {`
`1731`		`- efree(s);`
`1732`		`- }`
`1733`	`1730`	`}`
`1734`	`1731`	`/* }}} */`
`1735`	`1732`