Merge branch 'PHP-8.4'

nielsdos · nielsdos · commit df2436d35953 · 2024-10-30T20:56:16.000+01:00
* PHP-8.4:
  Fix static analysis warning
diff --git a/ext/dom/parentnode/tree.c b/ext/dom/parentnode/tree.c
@@ -500,7 +500,7 @@ static void dom_insert_node_list_cleanup(xmlNodePtr node)
 		xmlFreeNode(node);
 	} else {
 		/* Must have been a directly-passed node. */
-		ZEND_ASSERT(node->_private != NULL);
+		ZEND_UNREACHABLE();
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -500,7 +500,7 @@ static void dom_insert_node_list_cleanup(xmlNodePtr node)`
`500`	`500`	`xmlFreeNode(node);`
`501`	`501`	`} else {`
`502`	`502`	`/* Must have been a directly-passed node. */`
`503`		`- ZEND_ASSERT(node->_private != NULL);`
	`503`	`+ ZEND_UNREACHABLE();`
`504`	`504`	`}`
`505`	`505`	`}`
`506`	`506`