TODO Comment

Girgias · Girgias · commit dd4ed93dc1ea · 2020-09-03T17:39:18.000+02:00
diff --git a/ext/sodium/libsodium.c b/ext/sodium/libsodium.c
@@ -1785,6 +1785,7 @@ PHP_FUNCTION(sodium_crypto_pwhash_scryptsalsa208sha256_str_verify)
 		RETURN_THROWS();
 	}
 	if (hash_str_len != crypto_pwhash_scryptsalsa208sha256_STRBYTES - 1) {
+		/* Promote to Exception? */
 		zend_error(E_WARNING, "wrong size for the hashed password");
 		RETURN_FALSE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1785,6 +1785,7 @@ PHP_FUNCTION(sodium_crypto_pwhash_scryptsalsa208sha256_str_verify)`
`1785`	`1785`	`RETURN_THROWS();`
`1786`	`1786`	`}`
`1787`	`1787`	`if (hash_str_len != crypto_pwhash_scryptsalsa208sha256_STRBYTES - 1) {`
	`1788`	`+ /* Promote to Exception? */`
`1788`	`1789`	`zend_error(E_WARNING, "wrong size for the hashed password");`
`1789`	`1790`	`RETURN_FALSE;`
`1790`	`1791`	`}`