Merge branch 'mac-tests' into PHP-7.4

* mac-tests:
  fix mac tests on azure

Author: krakjoe

azure/macos/brew.yml

@@ -4,13 +4,17 @@ parameters:
 steps:
   - script: |
       /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
-      # see https://formulae.brew.sh/ for package names
-      brew install autoconf \
+    displayName: 'Install Homebrew'
+  - script: |
+      brew install pkg-config \
+                   autoconf \
                    automake \
                    libtool \
                    bison \
-                   re2c \
-                   pkg-config \
+                   re2c
+    displayName: 'Install Build Tools'
+  - script: |
+      brew install openssl@1.1 \
                    krb5 \
                    bzip2 \
                    enchant \
@@ -20,16 +24,15 @@ steps:
                    freetype \
                    intltool \
                    icu4c \
-                   readline \
                    libiconv \
                    zlib \
                    t1lib \
                    gd \
                    libzip \
                    gmp \
                    tidyp \
-                   libxml2\
-                   openssl@1.1 \
+                   libxml2 \
+                   libxslt \
                    postgresql
       brew link icu4c gettext --force
-    displayName: 'brew'
+    displayName: 'Install Build Dependencies'

azure/macos/job.yml

@@ -14,6 +14,8 @@ jobs:
         export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/krb5/lib/pkgconfig"
         export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/libffi/lib/pkgconfig"
         export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/libxml2/lib/pkgconfig"
+        export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/libxslt/lib/pkgconfig"
+        export PKG_CONFIG_PATH="$PKG_CONFIG_PATH:/usr/local/opt/zlib/lib/pkgconfig"
         ./buildconf --force
         ./configure ${{ parameters.configurationParameters }} \
             --prefix=/usr/local \
@@ -32,7 +34,6 @@ jobs:
             --enable-exif \
             --with-zip \
             --with-zlib \
-            --with-zlib-dir=/usr \
             --enable-soap \
             --enable-xmlreader \
             --with-xsl \
@@ -46,7 +47,7 @@ jobs:
             --with-readline=/usr/local/opt/readline \
             --enable-mbstring \
             --with-curl \
-            --with-gettext==/usr/local/opt/gettext \
+            --with-gettext=/usr/local/opt/gettext \
             --enable-sockets \
             --with-bz2=/usr/local/opt/bzip2 \
             --with-openssl \
@@ -79,9 +80,3 @@ jobs:
         configurationName: ${{ parameters.configurationName }}
         runTestsName: 'OpCache'
         runTestsParameters: -d zend_extension=opcache.so -d opcache.enable_cli=1
-    - ${{ if ne(variables['Build.SourceBranch'], 'refs/heads/PHP-7.4') }}:
-      - template: test.yml
-        parameters:
-          configurationName: ${{ parameters.configurationName }}
-          runTestsName: 'JIT'
-          runTestsParameters: -d zend_extension=opcache.so -d opcache.enable_cli=1 -d opcache.jit_buffer_size=16M

azure/macos/test.yml

@@ -7,6 +7,7 @@ steps:
       export TEST_PHP_JUNIT=junit.xml
       export REPORT_EXIT_STATUS=no
       export SKIP_IO_CAPTURE_TESTS=1
+      export CI_NO_IPV6=1
       rm -rf junit.xml | true
       /usr/local/bin/php run-tests.php -P -q \
           -j$(sysctl -n hw.ncpu) \
@@ -22,6 +23,6 @@ steps:
       testResultsFormat: 'JUnit'
       testResultsFiles: junit.xml
       testRunTitle: '${{ parameters.configurationName }} ${{ parameters.runTestsName }}'
-      failTaskOnFailedTests: false
+      failTaskOnFailedTests: true
     displayName: 'Export ${{ parameters.configurationName }} ${{ parameters.runTestsName }} Results'
     condition: or(succeeded(), failed())

ext/ffi/tests/100.phpt

@@ -8,6 +8,10 @@ try {
 } catch (Throwable $e) {
 	die('skip PHP symbols not available');
 }
+
+if (PHP_OS == "Darwin") {
+    die("xfail there is a known leak here");
+}
 ?>
 --INI--
 ffi.enable=1

ext/pcntl/tests/001.phpt

@@ -27,7 +27,7 @@ function test_exit_signal(){
 	$pid=pcntl_fork();
 
 	if ($pid==0) {
-		sleep(10);
+        while(1);
 		exit;
 	} else {
 		$options=0;

ext/sockets/tests/ipv6_skipif.inc

@@ -1,6 +1,7 @@
 <?php
-if (!defined("AF_INET6")) {
+if (getenv("CI_NO_IPV6") || !defined("AF_INET6")) {
 	die('skip no IPv6 support');
 }
 if (@stream_socket_client('udp://[::1]:8888') === false)
 	die('skip no IPv6 support');
+

ext/sockets/tests/mcast_ipv6_send.phpt

@@ -5,7 +5,7 @@ Multicast support: IPv6 send options
 if (!extension_loaded('sockets')) {
     die('skip sockets extension not available.');
 }
-if (!defined('IPPROTO_IPV6')) {
+if (getenv('CI_NO_IPV6') || !defined('IPPROTO_IPV6')) {
 	die('skip IPv6 not available.');
 }
 $level = IPPROTO_IPV6;

ext/sockets/tests/socket_create_listen-nobind.phpt

@@ -12,9 +12,12 @@ if (fileowner($filename) == 0) {
     unlink ($filename);
     die('SKIP Test cannot be run as root.');
 }
+if (@socket_create_listen(80)) {
+    die('SKIP Test cannot be run in environment that will allow binding to port 80 (azure)');
+}
 --FILE--
 <?php
-$sock = socket_create_listen(PHP_OS == "Darwin" ? 427 : 80);
+$sock = socket_create_listen(80);
 --EXPECTF--
 Warning: socket_create_listen(): unable to bind to given address [13]: Permission denied in %s on line %d
 --CLEAN--

ext/standard/tests/file/flock_basic.phpt

@@ -11,22 +11,26 @@ Description: PHP supports a portable way of locking complete files
 echo "*** Testing flock() fun with file and dir ***\n";
 $file_path = __DIR__;
 
-$file_handle = fopen("$file_path/lock.tmp", "w");
+$lock_file = preg_replace("~\.phpt?$~", null, __FILE__);
+
+$file_handle = fopen($lock_file, "w");
 var_dump(flock($file_handle, LOCK_SH|LOCK_NB));
 var_dump(flock($file_handle, LOCK_UN));
 var_dump(flock($file_handle, LOCK_EX));
 var_dump(flock($file_handle, LOCK_UN));
 fclose($file_handle);
-unlink("$file_path/lock.tmp");
+unlink($lock_file);
+
+$lock_dir = sprintf("%s.dir", preg_replace("~\.phpt?$~", null, __FILE__));
 
-mkdir("$file_path/dir");
-$dir_handle = opendir("$file_path/dir");
+mkdir($lock_dir);
+$dir_handle = opendir($lock_dir);
 var_dump(flock($dir_handle, LOCK_SH|LOCK_NB));
 var_dump(flock($dir_handle, LOCK_UN));
 var_dump(flock($dir_handle, LOCK_EX));
 var_dump(flock($dir_handle, LOCK_UN));
 closedir($dir_handle);
-rmdir("$file_path/dir");
+rmdir($lock_dir);
 
 echo "\n*** Done ***\n";
 ?>

ext/standard/tests/file/flock_error.phpt

@@ -10,7 +10,7 @@ Description: PHP supports a portable way of locking complete files
 
 echo "*** Testing error conditions ***\n";
 
-$file = __DIR__."/flock.tmp";
+$file = preg_replace("~\.phpt?$~", null, __FILE__);
 $fp = fopen($file, "w");
 
 /* array of operatons */

ext/standard/tests/file/flock_variation.phpt

@@ -10,7 +10,8 @@ Description: PHP supports a portable way of locking complete files
 
 echo "*** Testing flock() fun with the various operation and 
             wouldblock values                                ***\n";
-$file = __DIR__."/flock.tmp";
+
+$file = preg_replace("~\.phpt?$~", null, __FILE__);
 $fp = fopen($file, "w");
 
 /* array of operatons */

ext/standard/tests/streams/stream_socket_enable_crypto.phpt

@@ -10,6 +10,10 @@ if( substr(PHP_OS, 0, 3) == "WIN" ) {
 if (!extension_loaded("zlib")) {
 	print "skip - ZLIB extension not loaded";
 }
+
+if (PHP_OS == "Darwin") {
+    print "skip - OS is encoded in headers, tested header is non Darwin";
+}
 ?>
 --FILE--
 <?php

ext/zlib/tests/bug55544.phpt

@@ -10,6 +10,10 @@ if( substr(PHP_OS, 0, 3) == "WIN" ) {
 if (!extension_loaded("zlib")) {
 	print "skip - ZLIB extension not loaded";
 }
+
+if (PHP_OS == "Darwin") {
+    print "skip - OS is encoded in headers, tested header is non Darwin";
+}
 ?>
 --FILE--
 <?php

ext/zlib/tests/gzencode_variation1.phpt

@@ -961,6 +961,12 @@ static int do_cli(int argc, char **argv) /* {{{ */
 		}
 		request_started = 1;
 		CG(start_lineno) = lineno;
+
+		zend_register_bool_constant(
+			ZEND_STRL("PHP_CLI_PROCESS_TITLE"),
+			is_ps_title_available() == PS_TITLE_SUCCESS,
+			CONST_CS, 0);
+
 		*arg_excp = arg_free; /* reconstuct argv */
 
 		if (hide_argv) {

ext/zlib/tests/gzencode_variation2.phpt

@@ -6,7 +6,9 @@ Patrick Allaert patrickallaert@php.net
 --SKIPIF--
 <?php
 if (PHP_SAPI !== "cli")
-  die("skip");
+  die("skip cli process title not available in non-cli SAPI");
+if (!PHP_CLI_PROCESS_TITLE)
+  die("skip process title not available (disabled or unsupported)");
 ?>
 --FILE--
 <?php

sapi/cli/php_cli.c

@@ -2,6 +2,10 @@
 Check cli_process_title support on Unix
 --SKIPIF--
 <?php
+if (PHP_SAPI !== "cli")
+  die("skip cli process title not available in non-cli SAPI");
+if (!PHP_CLI_PROCESS_TITLE)
+  die("skip process title not available (disabled or unsupported)");
 if (strtoupper(substr(PHP_OS, 0, 3)) === 'WIN')
   die("skip");
 ?>

sapi/cli/tests/cli_get_process_title_basic.phpt

@@ -6,7 +6,9 @@ Patrick Allaert patrickallaert@php.net
 --SKIPIF--
 <?php
 if (PHP_SAPI !== "cli")
-  die("skip");
+  die("skip cli process title not available in non-cli SAPI");
+if (!PHP_CLI_PROCESS_TITLE)
+  die("skip process title not available (disabled or unsupported)");
 ?>
 --FILE--
 <?php