ext/posix: posix_isatty set errno for it too.

Close GH-13918

Author: devnexen

NEWS

@@ -173,6 +173,8 @@ PHP                                                                        NEWS
 
 - POSIX:
   . Added POSIX_SC_CHILD_MAX and POSIX_SC_CLK_TCK constants. (Jakub Zelenka)
+  . Updated posix_isatty to set the error number on file descriptors.
+    (David Carlier)
 
 - PSpell:
   . Moved to PECL. (Derick Rethans)

UPGRADING

@@ -383,6 +383,10 @@ PHP 8.4 UPGRADE NOTES
 - PGSQL:
   . pg_select, the conditions arguments accepts an empty array and is optional.
 
+- POSIX:
+  . posix_isatty now sets the error number when the file descriptor/stream argument
+    is invalid.
+
 - SPL:
   . SplPriorityQueue::insert() and SplPriorityQueue::recoverFromCorruption()
     now has a tentative return type of true

ext/posix/posix.c

@@ -521,11 +521,13 @@ PHP_FUNCTION(posix_isatty)
 
 	/* A valid file descriptor must fit in an int and be positive */
 	if (fd < 0 || fd > INT_MAX) {
+		POSIX_G(last_error) = EBADF;
 		RETURN_FALSE;
 	}
 	if (isatty(fd)) {
 		RETURN_TRUE;
 	} else {
+		POSIX_G(last_error) = errno;
 		RETURN_FALSE;
 	}
 }

ext/posix/tests/posix_isatty_value_errors.phpt

@@ -11,13 +11,19 @@ if (PHP_INT_SIZE != 8) die('skip C int is same size as zend_long');
 
 $values = [
     -1,
+    10024,
     2**50+1,
 ];
 
 foreach ($values as $value) {
     var_dump(posix_isatty($value));
+    var_dump(posix_strerror(posix_get_last_error()));
 }
 ?>
 --EXPECT--
 bool(false)
+string(19) "Bad file descriptor"
 bool(false)
+string(19) "Bad file descriptor"
+bool(false)
+string(19) "Bad file descriptor"