Tyson's prototype

Co-authored-by: Tyson Andre <tysonandre775@hotmail.com>

Author: kamil-tekiela

Zend/tests/falsetoarray.phpt

@@ -0,0 +1,91 @@
+--TEST--
+Autovivification of false to array
+--FILE--
+<?php
+
+// no
+$undef[] = 42;
+
+// no
+$null = null;
+$null[] = 42;
+
+// yes
+$false = false;
+$false[] = 42;
+
+// yes
+$ref = false;
+$ref2 = &$ref;
+$ref2[] = 42;
+
+echo "now function\n";
+function ffalse(bool $a, ?bool $b, &$c, ...$d) {
+    // yes
+    $a[] = 42;
+    // yes
+    $b[] = 42;
+    // yes
+    $c[] = 42;
+    // yes
+    $d[0][] = 42;
+}
+$ref = false;
+ffalse(false, false, $ref, false);
+
+echo "now class\n";
+class Cfalse {
+    public $def;
+    private $untyped = false;
+    static private $st = false;
+    static private $st2 = false;
+    static private $st3 = false;
+    public function __construct(public $pu, private $pr = false) {
+        // yes
+        $this->def = false;
+        $this->def[] = 42;
+        // yes
+        $this->untyped[] = 42;
+        // yes
+        self::$st[] = 42;
+        // yes
+        static::$st2[] = 42;
+        // yes
+        $this::$st3[] = 42;
+        // yes
+        $this->pu[] = 42;
+        // yes
+        $this->pr[] = 42;
+    }
+}
+new Cfalse(false, false);
+
+?>
+--EXPECTF--
+Deprecated: Automatic conversion of false to array is deprecated in %s
+
+Deprecated: Automatic conversion of false to array is deprecated in %s
+now function
+
+Deprecated: Automatic conversion of false to array is deprecated in %s
+
+Deprecated: Automatic conversion of false to array is deprecated in %s
+
+Deprecated: Automatic conversion of false to array is deprecated in %s
+
+Deprecated: Automatic conversion of false to array is deprecated in %s
+now class
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 43
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 45
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 47
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 49
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 51
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 53
+
+Deprecated: Automatic conversion of false to array is deprecated in %s on line 55

Zend/zend_execute.c

@@ -2290,6 +2290,9 @@ static zend_always_inline void zend_fetch_dimension_address(zval *result, zval *
 						return;
 					}
 				}
+				if (Z_TYPE_P(container) == IS_FALSE) {
+					zend_error(E_DEPRECATED, "Automatic conversion of false to array is deprecated");
+				}
 				array_init(container);
 				goto fetch_from_array;
 			} else {
@@ -2345,6 +2348,9 @@ static zend_always_inline void zend_fetch_dimension_address(zval *result, zval *
 				ZVAL_UNDEFINED_OP1();
 			}
 			if (type != BP_VAR_UNSET) {
+				if (Z_TYPE_P(container) == IS_FALSE) {
+					zend_error(E_DEPRECATED, "Automatic conversion of false to array is deprecated");
+				}
 				array_init(container);
 				goto fetch_from_array;
 			} else {
@@ -2873,6 +2879,12 @@ static zend_always_inline void zend_fetch_property_address(zval *result, zval *c
 
 	ZVAL_INDIRECT(result, ptr);
 	if (flags) {
+		if (flags == ZEND_FETCH_DIM_WRITE) {
+			if (Z_TYPE_P(ptr) == IS_FALSE) {
+				zend_error(E_DEPRECATED, "Automatic conversion of false to array is deprecated");
+			}
+		}
+
 		zend_property_info *prop_info;
 
 		if (prop_op_type == IS_CONST) {

Zend/zend_vm_def.h

@@ -1210,6 +1210,11 @@ ZEND_VM_C_LABEL(assign_dim_op_new_array):
 			if (OP1_TYPE == IS_CV && UNEXPECTED(Z_TYPE_INFO_P(container) == IS_UNDEF)) {
 				ZVAL_UNDEFINED_OP1();
 			}
+			
+			if (Z_TYPE_P(container) == IS_FALSE) {
+				zend_error(E_DEPRECATED, "Automatic conversion of false to array is deprecated");
+			}
+
 			ZVAL_ARR(container, zend_new_array(8));
 			ZEND_VM_C_GOTO(assign_dim_op_new_array);
 		} else {
@@ -2601,6 +2606,11 @@ ZEND_VM_C_LABEL(try_assign_dim_array):
 				FREE_OP_DATA();
 			}
 		} else if (EXPECTED(Z_TYPE_P(object_ptr) <= IS_FALSE)) {
+
+			if (Z_TYPE_P(object_ptr) == IS_FALSE) {
+				zend_error(E_DEPRECATED, "Automatic conversion of false to array is deprecated");
+			}
+
 			if (Z_ISREF_P(orig_object_ptr)
 			 && ZEND_REF_HAS_TYPE_SOURCES(Z_REF_P(orig_object_ptr))
 			 && !zend_verify_ref_array_assignable(Z_REF_P(orig_object_ptr))) {