Skip to content

Commit d9628b9

Browse files
committed
Update the default values of xmlwriter_write_dtd_entity()
Its default method handling had already been fixed not long ago, but only the stub of its method counterpart was updated.
1 parent 34bb5ba commit d9628b9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

ext/xmlwriter/php_xmlwriter.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function xmlwriter_start_dtd_entity(XMLWriter $xmlwriter, string $name, bool $is
8080

8181
function xmlwriter_end_dtd_entity(XMLWriter $xmlwriter): bool {}
8282

83-
function xmlwriter_write_dtd_entity(XMLWriter $xmlwriter, string $name, string $content, bool $isparam = false, string $publicId = UNKNOWN, string $systemId = UNKNOWN, string $ndataid = UNKNOWN): bool {}
83+
function xmlwriter_write_dtd_entity(XMLWriter $xmlwriter, string $name, string $content, bool $isparam = false, ?string $publicId = null, ?string $systemId = null, ?string $ndataid = null): bool {}
8484

8585
function xmlwriter_output_memory(XMLWriter $xmlwriter, bool $flush = true): string {}
8686

ext/xmlwriter/php_xmlwriter_arginfo.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* This is a generated file, edit the .stub.php file instead.
2-
* Stub hash: 7a12c6f16e2a21c8b57ec963ed7e5fa230e425aa */
2+
* Stub hash: b1a8634bf79e1ac8fb94611ab942e9e4c06636f9 */
33

44
ZEND_BEGIN_ARG_WITH_RETURN_OBJ_TYPE_MASK_EX(arginfo_xmlwriter_open_uri, 0, 1, XMLWriter, MAY_BE_FALSE)
55
ZEND_ARG_TYPE_INFO(0, uri, IS_STRING, 0)
@@ -160,9 +160,9 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_xmlwriter_write_dtd_entity, 0, 3
160160
ZEND_ARG_TYPE_INFO(0, name, IS_STRING, 0)
161161
ZEND_ARG_TYPE_INFO(0, content, IS_STRING, 0)
162162
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, isparam, _IS_BOOL, 0, "false")
163-
ZEND_ARG_TYPE_INFO(0, publicId, IS_STRING, 0)
164-
ZEND_ARG_TYPE_INFO(0, systemId, IS_STRING, 0)
165-
ZEND_ARG_TYPE_INFO(0, ndataid, IS_STRING, 0)
163+
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, publicId, IS_STRING, 1, "null")
164+
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, systemId, IS_STRING, 1, "null")
165+
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, ndataid, IS_STRING, 1, "null")
166166
ZEND_END_ARG_INFO()
167167

168168
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_xmlwriter_output_memory, 0, 1, IS_STRING, 0)

0 commit comments

Comments
 (0)