- add a note about the actual problen so we don't forget it

pierrejoye · pierrejoye · commit d8b76a84116a · 2009-05-26T08:10:49.000Z
diff --git a/ext/xmlwriter/php_xmlwriter.c b/ext/xmlwriter/php_xmlwriter.c
@@ -1781,6 +1781,9 @@ static PHP_FUNCTION(xmlwriter_open_uri)
 		RETURN_FALSE;
 	}
 
+	/* TODO: Fix either the PHP stream or libxml APIs: it can then detect when a given 
+		 path is valid and not report out of memory error. Once it is done, remove the
+		 directory check in _xmlwriter_get_valid_file_path */
 #ifndef ZEND_ENGINE_2
 	ioctx = php_xmlwriter_streams_IO_open_write_wrapper(valid_file TSRMLS_CC);
 	if (ioctx == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -1781,6 +1781,9 @@ static PHP_FUNCTION(xmlwriter_open_uri)`
`1781`	`1781`	`RETURN_FALSE;`
`1782`	`1782`	`}`
`1783`	`1783`
	`1784`	`+ /* TODO: Fix either the PHP stream or libxml APIs: it can then detect when a given`
	`1785`	`+ path is valid and not report out of memory error. Once it is done, remove the`
	`1786`	`+ directory check in _xmlwriter_get_valid_file_path */`
`1784`	`1787`	`#ifndef ZEND_ENGINE_2`
`1785`	`1788`	`ioctx = php_xmlwriter_streams_IO_open_write_wrapper(valid_file TSRMLS_CC);`
`1786`	`1789`	`if (ioctx == NULL) {`