Skip to content

Commit d6d9024

Browse files
committed
Avoid use of random ports in some socket tests
1 parent a023eb3 commit d6d9024

File tree

6 files changed

+8
-14
lines changed

6 files changed

+8
-14
lines changed

ext/sockets/tests/socket_bind.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ fa@php.net
1414
?>
1515
--FILE--
1616
<?php
17-
$rand = rand(1,999);
1817
$s_c = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
19-
$s_bind = socket_bind($s_c, '0.0.0.0', 31330+$rand);
18+
$s_bind = socket_bind($s_c, '0.0.0.0');
2019
var_dump($s_bind);
2120

2221
// Connect to destination address

ext/sockets/tests/socket_getpeername.phpt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
ext/sockets - socket_getsockname - basic test
2+
ext/sockets - socket_getpeername - basic test
33
--CREDITS--
44
Florian Anderiasch
55
fa@php.net
@@ -11,9 +11,8 @@ fa@php.net
1111
?>
1212
--FILE--
1313
<?php
14-
$rand = rand(1,999);
1514
$s_c = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
16-
$s_bind = socket_bind($s_c, '0.0.0.0', 31330+$rand);
15+
$s_bind = socket_bind($s_c, '0.0.0.0');
1716
var_dump($s_bind);
1817

1918
// Connect to destination address

ext/sockets/tests/socket_getsockname.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ fa@php.net
1111
?>
1212
--FILE--
1313
<?php
14-
$rand = rand(1,999);
1514
$s_c = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
16-
$s_bind = socket_bind($s_c, '0.0.0.0', 31330+$rand);
15+
$s_bind = socket_bind($s_c, '0.0.0.0');
1716
var_dump($s_bind);
1817

1918
// Connect to destination address

ext/sockets/tests/socket_send_params.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ ext/sockets - socket_send - test with incorrect parameters
88
?>
99
--FILE--
1010
<?php
11-
$rand = rand(1,999);
12-
$s_c = socket_create_listen(31330+$rand);
11+
$s_c = socket_create_listen(0);
1312
$s_w = socket_send($s_c, "foo", -1, MSG_OOB);
1413
socket_close($s_c);
1514
?>

ext/sockets/tests/socket_sendto_params.phpt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ ext/sockets - socket_sendto - test with incorrect parameters
88
?>
99
--FILE--
1010
<?php
11-
$rand = rand(1,999);
12-
$s_c = socket_create_listen(31330+$rand);
11+
$s_c = socket_create_listen(0);
1312
$s_w = socket_sendto($s_c, "foo", -1, MSG_OOB, '127.0.0.1');
1413
socket_close($s_c);
1514
?>

ext/sockets/tests/socket_set_nonblock.phpt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ fa@php.net
1111
?>
1212
--FILE--
1313
<?php
14-
$rand = rand(1,999);
15-
$s_c_l = socket_create_listen(31330+$rand);
14+
$s_c_l = socket_create_listen(0);
1615
socket_set_nonblock($s_c_l);
1716
var_dump($s_c_l);
18-
#socket_accept($s_c_l);
17+
//socket_accept($s_c_l);
1918
socket_close($s_c_l);
2019
?>
2120
--EXPECTF--

0 commit comments

Comments
 (0)