Add tests and try to resolve bound closure

Author: Girgias

ext/reflection/php_reflection.c

@@ -1645,8 +1645,13 @@ ZEND_METHOD(ReflectionFunction, __construct)
 		Z_PARAM_OBJ_OF_CLASS_OR_STR(closure_obj, zend_ce_closure, fname)
 	ZEND_PARSE_PARAMETERS_END();
 
+	/* Set CE to NULL */
+	intern->ce = NULL;
 	if (closure_obj) {
 		fptr = (zend_function*)zend_get_closure_method_def(closure_obj);
+		//zend_object *tmp = NULL;
+		///* We use the get_closure object handler that always succeds to fetch the function and CE pointers */
+		//closure_obj->handlers->get_closure(closure_obj, &intern->ce, &fptr, /* obj_ptr */ &tmp, /* check_only */ false);
 	} else {
 		if (UNEXPECTED(ZSTR_VAL(fname)[0] == '\\')) {
 			/* Ignore leading "\" */
@@ -1681,7 +1686,6 @@ ZEND_METHOD(ReflectionFunction, __construct)
 	} else {
 		ZVAL_UNDEF(&intern->obj);
 	}
-	intern->ce = NULL;
 }
 /* }}} */
 

ext/reflection/tests/types/relative_class_types/closure_bound_resolvable_relative_types.phpt

@@ -0,0 +1,43 @@
+--TEST--
+ReflectionTypes of relative class types (self, parent) from traits in classes, variadic parameter DNF types
+--XFAIL--
+I'm confused why it not possible to chope the bound scope via Reflection
+--FILE--
+<?php
+
+class A {}
+class B extends A {}
+
+$fnSelf = function (): self { };
+$fnParent = function (): parent {};
+$fnStatic = function (): static {};
+
+$instances = [
+    $fnSelf,
+    $fnParent,
+    $fnStatic,
+];
+
+$b = new B();
+
+// TODO Method getClosureScopeClass() seems useful
+// TODO Need to pass scope to: ZEND_METHOD(ReflectionFunctionAbstract, getParameters) ?
+// TODO Need to pass scope to: ZEND_METHOD(ReflectionFunctionAbstract, getReturnType) ?
+foreach ($instances as $instance) {
+    $instance->bindTo($b);
+    $rc = new ReflectionFunction($instance);
+    echo "\tBound to: ", $rc->getClosureScopeClass()->name, PHP_EOL;
+    $type = $rc->getReturnType();
+    echo "\tType: ", $type, PHP_EOL;
+    echo "\tInstance of: ", $type::class, PHP_EOL;
+    try {
+        $resolvedType = $type->resolveToNamedType();
+        echo "\t\tResolved Type: ", $resolvedType, PHP_EOL;
+        echo "\t\tInstance of: ", $resolvedType::class, PHP_EOL;
+    } catch (\Throwable $e) {
+        echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+    }
+}
+
+?>
+--EXPECT--

ext/reflection/tests/types/relative_class_types/closure_unresolvable_relative_types.phpt

@@ -0,0 +1,40 @@
+--TEST--
+ReflectionTypes of relative class types (self, parent) from traits in classes, variadic parameter DNF types
+--FILE--
+<?php
+
+$fnSelf = function (): self { };
+$fnParent = function (): parent {};
+$fnStatic = function (): static {};
+
+$instances = [
+    $fnSelf,
+    $fnParent,
+    $fnStatic,
+];
+
+foreach ($instances as $instance) {
+    $rc = new ReflectionFunction($instance);
+    $type = $rc->getReturnType();
+    echo "\t\tType: ", $type, PHP_EOL;
+    echo "\t\tInstance of: ", $type::class, PHP_EOL;
+    try {
+        $resolvedType = $type->resolveToNamedType();
+        echo "\t\t\tResolved Type: ", $resolvedType, PHP_EOL;
+        echo "\t\t\tInstance of: ", $resolvedType::class, PHP_EOL;
+    } catch (\Throwable $e) {
+        echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+    }
+}
+
+?>
+--EXPECT--
+Type: self
+		Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a closure
+		Type: parent
+		Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a closure
+		Type: static
+		Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a closure

ext/reflection/tests/types/relative_class_types/traits_unresolvable_relative_types.phpt

@@ -0,0 +1,42 @@
+--TEST--
+ReflectionTypes of relative class types (self, parent) from traits in classes, variadic parameter DNF types
+--FILE--
+<?php
+
+trait TraitExample {
+    public function bar(object $o): parent { return $o; }
+    public function ping(object $o): self { return $o; }
+    public function pong(object $o): static { return $o; }
+}
+
+$rc = new ReflectionClass('TraitExample');
+
+$methods = $rc->getMethods();
+foreach ($methods as $method) {
+    echo "Method: ", $method->name, PHP_EOL;
+    $type = $method->getReturnType();
+    echo "\tType: ", $type, PHP_EOL;
+    echo "\tInstance of: ", $type::class, PHP_EOL;
+    try {
+        $resolvedType = $type->resolveToNamedType();
+        echo "\t\tResolved Type: ", $resolvedType, PHP_EOL;
+        echo "\t\tInstance of: ", $resolvedType::class, PHP_EOL;
+    } catch (\Throwable $e) {
+        echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+    }
+}
+
+?>
+--EXPECT--
+Method: bar
+	Type: parent
+	Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a trait
+Method: ping
+	Type: self
+	Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a trait
+Method: pong
+	Type: static
+	Instance of: ReflectionRelativeClassType
+ReflectionException: Cannot resolve relative class name for a trait