Skip to content

Commit d66a6ba

Browse files
committed
Mention that an API bump must be done with RC1
It's okay to change the API change up until the first release candidate only, and it may not be changed afterwards. There is a discussion at https://github.com/php/php-src/pull/4470/files that never resulted in a fix. /cc @sgolemon @carusogabriel
1 parent 54e15dc commit d66a6ba

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

docs/release-process.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,12 @@
9393
beta. Do not use dashes, you should `#define PHP_VERSION "7.4.22RC1"` and
9494
not `#define PHP_VERSION "7.4.22-RC1"`.
9595

96-
When releasing the first alpha version, bump also API version numbers in
97-
`Zend/zend_extensions.h`, `Zend/zend_modules.h`, and `main/php.h`. The API
98-
versions between the alpha/beta/.0RCx releases can be left the same or
99-
bumped as little as possible because PHP extensions will need to be rebuilt
100-
with each bump.
96+
When releasing the first release candidate, you must also bump the API
97+
version numbers in `Zend/zend_extensions.h`, `Zend/zend_modules.h`, and
98+
`main/php.h`. The API versions between the alpha/beta/.0RCx releases can be
99+
left the same, or bumped as little as possible because PHP extensions will
100+
need to be rebuilt with each bump. Do *not* bump the API versions after
101+
RC1.
101102

102103
6. Compile and run `make test`, with and without ZTS, using the right Bison and
103104
re2c version (for PHP 7.4, minimum Bison 3.0.0 and re2c 0.13.4 are used).

0 commit comments

Comments
 (0)