File tree Expand file tree Collapse file tree 1 file changed +2
-2
lines changed Expand file tree Collapse file tree 1 file changed +2
-2
lines changed Original file line number Diff line number Diff line change @@ -138,10 +138,10 @@ const phpdbg_command_t phpdbg_watch_commands[] = {
138
138
bool phpdbg_check_watch_diff (phpdbg_watchtype type , void * oldPtr , void * newPtr ) {
139
139
switch (type ) {
140
140
case WATCH_ON_BUCKET :
141
- if (memcmp (& ((Bucket * ) oldPtr )-> h , & ((Bucket * ) newPtr )-> h , sizeof (Bucket ) - sizeof (zval ) /* key/val comparison */ ) != 0 ) {
141
+ if (memcmp (& ((Bucket * ) oldPtr )-> h , & ((Bucket * ) newPtr )-> h , sizeof (Bucket ) - sizeof (zval ) /* hash+ key comparison */ ) != 0 ) {
142
142
return 2 ;
143
143
}
144
- /* TODO: Is this intentional? */
144
+ /* Fall through to also compare the value from the bucket. */
145
145
ZEND_FALLTHROUGH ;
146
146
case WATCH_ON_ZVAL :
147
147
return memcmp (oldPtr , newPtr , sizeof (zend_value ) + sizeof (uint32_t ) /* value + typeinfo */ ) != 0 ;
You can’t perform that action at this time.
0 commit comments