ext/pgsql: get_field_name helper, remove unused precaution for pg_type request. (#18025)

devnexen · web-flow · commit d5251513b1fd · 2025-03-19T21:56:00.000Z
it is an internal table and oid is a real Oid (uint32_t) value.
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
@@ -1670,8 +1670,7 @@ static zend_string *get_field_name(PGconn *pgsql, Oid oid)
 			continue;
 		}
 
-		char *end_ptr;
-		Oid tmp_oid = strtoul(tmp_oid_str, &end_ptr, 10);
+		Oid tmp_oid = strtoul(tmp_oid_str, NULL, 10);
 
 		zend_string *name = zend_string_init(tmp_name, strlen(tmp_name), 0);
 		zend_hash_index_update_ptr(&PGG(field_oids), tmp_oid, name);

Original file line number	Diff line number	Diff line change
`@@ -1670,8 +1670,7 @@ static zend_string get_field_name(PGconn pgsql, Oid oid)`
`1670`	`1670`	`continue;`
`1671`	`1671`	`}`
`1672`	`1672`
`1673`		`- char *end_ptr;`
`1674`		`- Oid tmp_oid = strtoul(tmp_oid_str, &end_ptr, 10);`
	`1673`	`+ Oid tmp_oid = strtoul(tmp_oid_str, NULL, 10);`
`1675`	`1674`
`1676`	`1675`	`zend_string *name = zend_string_init(tmp_name, strlen(tmp_name), 0);`
`1677`	`1676`	`zend_hash_index_update_ptr(&PGG(field_oids), tmp_oid, name);`