Use E_ERROR to report arginfo/zpp mismatch

nikic · nikic · commit d4aff2547333 · 2021-02-09T14:36:44.000+01:00
When E_CORE_ERROR is used, we don't get correct file/line information.
diff --git a/Zend/zend_execute.c b/Zend/zend_execute.c
@@ -1144,7 +1144,7 @@ static zend_always_inline zend_bool zend_internal_call_should_throw(zend_functio
 
 static ZEND_COLD void zend_internal_call_arginfo_violation(zend_function *fbc)
 {
-	zend_error(E_CORE_ERROR, "Arginfo / zpp mismatch during call of %s%s%s()",
+	zend_error(E_ERROR, "Arginfo / zpp mismatch during call of %s%s%s()",
 		fbc->common.scope ? ZSTR_VAL(fbc->common.scope->name) : "",
 		fbc->common.scope ? "::" : "",
 		ZSTR_VAL(fbc->common.function_name));

Original file line number	Diff line number	Diff line change
`@@ -1144,7 +1144,7 @@ static zend_always_inline zend_bool zend_internal_call_should_throw(zend_functio`
`1144`	`1144`
`1145`	`1145`	`static ZEND_COLD void zend_internal_call_arginfo_violation(zend_function *fbc)`
`1146`	`1146`	`{`
`1147`		`- zend_error(E_CORE_ERROR, "Arginfo / zpp mismatch during call of %s%s%s()",`
	`1147`	`+ zend_error(E_ERROR, "Arginfo / zpp mismatch during call of %s%s%s()",`
`1148`	`1148`	`fbc->common.scope ? ZSTR_VAL(fbc->common.scope->name) : "",`
`1149`	`1149`	`fbc->common.scope ? "::" : "",`
`1150`	`1150`	`ZSTR_VAL(fbc->common.function_name));`