Skip xleak tests on asan (#11610)

iluuu1994 · web-flow · commit d397fec12955 · 2023-07-07T09:24:05.000+02:00
Fixes GH-11077
diff --git a/run-tests.php b/run-tests.php
@@ -2477,7 +2477,10 @@ function run_test(string $php, $file, array $env): string
     if ($test->hasSection('XLEAK')) {
         $env['ZEND_ALLOC_PRINT_LEAKS'] = '0';
         if (isset($env['SKIP_ASAN'])) {
-            $env['LSAN_OPTIONS'] = 'detect_leaks=0';
+            // $env['LSAN_OPTIONS'] = 'detect_leaks=0';
+            /* For unknown reasons, LSAN_OPTIONS=detect_leaks=0 would occasionally not be picked up
+             * in CI. Skip the test with ASAN, as it's not worth investegating. */
+            return skip_test($tested, $tested_file, $shortname, 'xleak does not work with asan');
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2477,7 +2477,10 @@ function run_test(string $php, $file, array $env): string`
`2477`	`2477`	`if ($test->hasSection('XLEAK')) {`
`2478`	`2478`	`$env['ZEND_ALLOC_PRINT_LEAKS'] = '0';`
`2479`	`2479`	`if (isset($env['SKIP_ASAN'])) {`
`2480`		`- $env['LSAN_OPTIONS'] = 'detect_leaks=0';`
	`2480`	`+ // $env['LSAN_OPTIONS'] = 'detect_leaks=0';`
	`2481`	`+ /* For unknown reasons, LSAN_OPTIONS=detect_leaks=0 would occasionally not be picked up`
	`2482`	`+ * in CI. Skip the test with ASAN, as it's not worth investegating. */`
	`2483`	`+ return skip_test($tested, $tested_file, $shortname, 'xleak does not work with asan');`
`2481`	`2484`	`}`
`2482`	`2485`	`}`
`2483`	`2486`