Skip to content

Commit d3901b8

Browse files
authored
Sync PHP_FILEINFO_UNCOMPRESS #if/ifdef/defined (#14525)
This fixes few more -Wundef warnings in ext/fileinfo. The PHP_FILEINFO_UNCOMPRESS seems to be present to be defined at some point but is currently unused in all build systems. Leaving this intact for now. Follow up of GH-5526 (-Wundef)
1 parent 8918574 commit d3901b8

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

ext/fileinfo/libmagic.patch

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
diff -u libmagic.orig/apprentice.c libmagic/apprentice.c
22
--- libmagic.orig/apprentice.c 2023-07-17 16:38:35.000000000 +0200
3-
+++ libmagic/apprentice.c 2024-05-27 16:08:06.689332368 +0200
3+
+++ libmagic/apprentice.c 2024-06-09 00:31:40.345830732 +0200
44
@@ -48,7 +48,9 @@
55
#ifdef QUICK
66
#include <sys/mman.h>
@@ -870,7 +870,7 @@ diff -u libmagic.orig/apprentice.c libmagic/apprentice.c
870870
break;
871871
diff -u libmagic.orig/ascmagic.c libmagic/ascmagic.c
872872
--- libmagic.orig/ascmagic.c 2023-05-30 22:17:50.000000000 +0200
873-
+++ libmagic/ascmagic.c 2024-05-27 16:08:06.689332368 +0200
873+
+++ libmagic/ascmagic.c 2024-06-09 00:31:40.345830732 +0200
874874
@@ -96,7 +96,7 @@
875875
rv = file_ascmagic_with_encoding(ms, &bb,
876876
ubuf, ulen, code, type, text);
@@ -912,7 +912,7 @@ diff -u libmagic.orig/ascmagic.c libmagic/ascmagic.c
912912
}
913913
diff -u libmagic.orig/buffer.c libmagic/buffer.c
914914
--- libmagic.orig/buffer.c 2023-07-02 14:48:39.000000000 +0200
915-
+++ libmagic/buffer.c 2024-05-27 16:08:06.689332368 +0200
915+
+++ libmagic/buffer.c 2024-06-09 00:31:40.345830732 +0200
916916
@@ -31,19 +31,21 @@
917917
#endif /* lint */
918918

@@ -971,7 +971,7 @@ diff -u libmagic.orig/buffer.c libmagic/buffer.c
971971
}
972972
diff -u libmagic.orig/cdf.c libmagic/cdf.c
973973
--- libmagic.orig/cdf.c 2022-09-24 22:56:49.000000000 +0200
974-
+++ libmagic/cdf.c 2024-05-27 16:08:06.689332368 +0200
974+
+++ libmagic/cdf.c 2024-06-09 00:31:40.345830732 +0200
975975
@@ -43,7 +43,9 @@
976976
#include <err.h>
977977
#endif
@@ -1202,7 +1202,7 @@ diff -u libmagic.orig/cdf.c libmagic/cdf.c
12021202
#endif
12031203
diff -u libmagic.orig/cdf.h libmagic/cdf.h
12041204
--- libmagic.orig/cdf.h 2022-09-24 22:56:49.000000000 +0200
1205-
+++ libmagic/cdf.h 2024-05-27 16:08:06.690332378 +0200
1205+
+++ libmagic/cdf.h 2024-06-04 15:10:40.600783222 +0200
12061206
@@ -37,8 +37,6 @@
12071207

12081208
#ifdef WIN32
@@ -1214,7 +1214,7 @@ diff -u libmagic.orig/cdf.h libmagic/cdf.h
12141214
#define timespec timeval
12151215
diff -u libmagic.orig/compress.c libmagic/compress.c
12161216
--- libmagic.orig/compress.c 2023-05-21 17:59:58.000000000 +0200
1217-
+++ libmagic/compress.c 2024-05-27 16:08:06.690332378 +0200
1217+
+++ libmagic/compress.c 2024-06-09 00:31:40.346830746 +0200
12181218
@@ -63,13 +63,14 @@
12191219
#if defined(HAVE_SYS_TIME_H)
12201220
#include <sys/time.h>
@@ -1333,7 +1333,7 @@ diff -u libmagic.orig/compress.c libmagic/compress.c
13331333
+#endif
13341334
diff -u libmagic.orig/der.c libmagic/der.c
13351335
--- libmagic.orig/der.c 2022-09-24 22:56:49.000000000 +0200
1336-
+++ libmagic/der.c 2024-05-27 16:08:06.690332378 +0200
1336+
+++ libmagic/der.c 2024-06-09 00:31:40.346830746 +0200
13371337
@@ -54,7 +54,9 @@
13381338
#include "magic.h"
13391339
#include "der.h"
@@ -1346,7 +1346,7 @@ diff -u libmagic.orig/der.c libmagic/der.c
13461346
#endif
13471347
diff -u libmagic.orig/encoding.c libmagic/encoding.c
13481348
--- libmagic.orig/encoding.c 2022-12-26 18:31:56.000000000 +0100
1349-
+++ libmagic/encoding.c 2024-05-27 16:08:06.690332378 +0200
1349+
+++ libmagic/encoding.c 2024-06-09 00:31:40.346830746 +0200
13501350
@@ -97,7 +97,7 @@
13511351
nbytes = ms->encoding_max;
13521352

@@ -1382,7 +1382,7 @@ diff -u libmagic.orig/encoding.c libmagic/encoding.c
13821382
}
13831383
diff -u libmagic.orig/file.h libmagic/file.h
13841384
--- libmagic.orig/file.h 2023-07-27 21:40:22.000000000 +0200
1385-
+++ libmagic/file.h 2024-05-27 16:08:06.690332378 +0200
1385+
+++ libmagic/file.h 2024-06-09 00:31:40.346830746 +0200
13861386
@@ -27,15 +27,13 @@
13871387
*/
13881388
/*
@@ -1583,7 +1583,7 @@ diff -u libmagic.orig/file.h libmagic/file.h
15831583
#define QUICK
15841584
diff -u libmagic.orig/fsmagic.c libmagic/fsmagic.c
15851585
--- libmagic.orig/fsmagic.c 2023-07-27 21:33:24.000000000 +0200
1586-
+++ libmagic/fsmagic.c 2024-05-27 16:08:06.690332378 +0200
1586+
+++ libmagic/fsmagic.c 2024-06-09 00:31:40.346830746 +0200
15871587
@@ -66,26 +66,10 @@
15881588
# define minor(dev) ((dev) & 0xff)
15891589
#endif
@@ -1876,7 +1876,7 @@ diff -u libmagic.orig/fsmagic.c libmagic/fsmagic.c
18761876
case S_IFSOCK:
18771877
diff -u libmagic.orig/funcs.c libmagic/funcs.c
18781878
--- libmagic.orig/funcs.c 2023-07-27 21:40:12.000000000 +0200
1879-
+++ libmagic/funcs.c 2024-05-27 16:08:06.690332378 +0200
1879+
+++ libmagic/funcs.c 2024-06-09 17:55:33.549243946 +0200
18801880
@@ -66,7 +66,7 @@
18811881
file_private void
18821882
file_clearbuf(struct magic_set *ms)
@@ -1969,7 +1969,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
19691969
#endif
19701970
-#if HAVE_FORK
19711971
+
1972-
+#if PHP_FILEINFO_UNCOMPRESS
1972+
+#ifdef PHP_FILEINFO_UNCOMPRESS
19731973
/* try compression stuff */
19741974
if ((ms->flags & MAGIC_NO_CHECK_COMPRESS) == 0) {
19751975
m = file_zmagic(ms, &b, inname);
@@ -1987,7 +1987,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
19871987
rv = -1;
19881988
}
19891989
-#if HAVE_FORK
1990-
+#if PHP_FILEINFO_UNCOMPRESS
1990+
+#ifdef PHP_FILEINFO_UNCOMPRESS
19911991
done_encoding:
19921992
#endif
19931993
- free(rbuf);
@@ -2222,7 +2222,7 @@ diff -u libmagic.orig/funcs.c libmagic/funcs.c
22222222
file_clear_closexec(int fd) {
22232223
diff -u libmagic.orig/magic.c libmagic/magic.c
22242224
--- libmagic.orig/magic.c 2023-07-27 21:33:24.000000000 +0200
2225-
+++ libmagic/magic.c 2024-05-27 16:08:06.691332388 +0200
2225+
+++ libmagic/magic.c 2024-06-09 00:31:40.347830761 +0200
22262226
@@ -25,11 +25,6 @@
22272227
* SUCH DAMAGE.
22282228
*/
@@ -2695,8 +2695,8 @@ diff -u libmagic.orig/magic.c libmagic/magic.c
26952695
}
26962696
return file_getbuffer(ms);
26972697
diff -u libmagic.orig/magic.h libmagic/magic.h
2698-
--- libmagic.orig/magic.h 2024-05-28 16:08:42.589182799 +0200
2699-
+++ libmagic/magic.h 2024-05-27 16:08:06.691332388 +0200
2698+
--- libmagic.orig/magic.h 2024-06-09 17:55:50.382419678 +0200
2699+
+++ libmagic/magic.h 2024-06-09 00:31:40.347830761 +0200
27002700
@@ -47,8 +47,6 @@
27012701
* extensions */
27022702
#define MAGIC_COMPRESS_TRANSP 0x2000000 /* Check inside compressed files
@@ -2749,7 +2749,7 @@ diff -u libmagic.orig/magic.h libmagic/magic.h
27492749
int magic_getparam(magic_t, int, void *);
27502750
diff -u libmagic.orig/print.c libmagic/print.c
27512751
--- libmagic.orig/print.c 2023-07-27 20:04:45.000000000 +0200
2752-
+++ libmagic/print.c 2024-05-27 16:08:06.691332388 +0200
2752+
+++ libmagic/print.c 2024-06-09 00:31:40.347830761 +0200
27532753
@@ -73,7 +73,7 @@
27542754
if (m->mask_op & FILE_OPINVERSE)
27552755
(void) fputc('~', stderr);
@@ -2806,7 +2806,7 @@ diff -u libmagic.orig/print.c libmagic/print.c
28062806
goto out;
28072807
diff -u libmagic.orig/readcdf.c libmagic/readcdf.c
28082808
--- libmagic.orig/readcdf.c 2023-02-09 18:43:53.000000000 +0100
2809-
+++ libmagic/readcdf.c 2024-05-27 16:08:06.691332388 +0200
2809+
+++ libmagic/readcdf.c 2024-06-09 00:31:40.347830761 +0200
28102810
@@ -31,7 +31,9 @@
28112811

28122812
#include <assert.h>
@@ -2926,7 +2926,7 @@ diff -u libmagic.orig/readcdf.c libmagic/readcdf.c
29262926
if (i != -1)
29272927
diff -u libmagic.orig/softmagic.c libmagic/softmagic.c
29282928
--- libmagic.orig/softmagic.c 2023-07-27 21:40:12.000000000 +0200
2929-
+++ libmagic/softmagic.c 2024-05-27 16:08:06.691332388 +0200
2929+
+++ libmagic/softmagic.c 2024-06-09 00:31:40.347830761 +0200
29302930
@@ -45,7 +45,7 @@
29312931
#include <time.h>
29322932
#include "der.h"

ext/fileinfo/libmagic/funcs.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ file_buffer(struct magic_set *ms, php_stream *stream, zend_stat_t *st,
371371
}
372372
#endif
373373

374-
#if PHP_FILEINFO_UNCOMPRESS
374+
#ifdef PHP_FILEINFO_UNCOMPRESS
375375
/* try compression stuff */
376376
if ((ms->flags & MAGIC_NO_CHECK_COMPRESS) == 0) {
377377
m = file_zmagic(ms, &b, inname);
@@ -507,7 +507,7 @@ file_buffer(struct magic_set *ms, php_stream *stream, zend_stat_t *st,
507507
if (file_printf(ms, "%s", code_mime) == -1)
508508
rv = -1;
509509
}
510-
#if PHP_FILEINFO_UNCOMPRESS
510+
#ifdef PHP_FILEINFO_UNCOMPRESS
511511
done_encoding:
512512
#endif
513513
efree(rbuf);

0 commit comments

Comments
 (0)