Skip to content

Commit d1fc001

Browse files
committed
Revert "Fix compilation on MacOS"
This reverts commit 800c667. Reverted along with a01dd9f.
1 parent 5a0b68b commit d1fc001

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

ext/spl/spl_array.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,11 @@ static zend_object *spl_array_object_new_ex(zend_class_entry *class_type, zend_o
177177
}
178178

179179
while (parent) {
180-
if (parent == spl_ce_ArrayIterator || parent == spl_ce_RecursiveArrayIterator || parent == spl_ce_ArrayObject) {
180+
if (parent == spl_ce_ArrayIterator || parent == spl_ce_RecursiveArrayIterator) {
181+
intern->std.handlers = &spl_handler_ArrayIterator;
182+
break;
183+
} else if (parent == spl_ce_ArrayObject) {
184+
intern->std.handlers = &spl_handler_ArrayObject;
181185
break;
182186
}
183187
parent = parent->parent;
@@ -1777,7 +1781,6 @@ PHP_MINIT_FUNCTION(spl_array)
17771781
{
17781782
spl_ce_ArrayObject = register_class_ArrayObject(zend_ce_aggregate, zend_ce_arrayaccess, zend_ce_serializable, zend_ce_countable);
17791783
spl_ce_ArrayObject->create_object = spl_array_object_new;
1780-
spl_ce_ArrayObject->default_object_handlers = &spl_handler_ArrayObject;
17811784

17821785
memcpy(&spl_handler_ArrayObject, &std_object_handlers, sizeof(zend_object_handlers));
17831786

@@ -1803,7 +1806,6 @@ PHP_MINIT_FUNCTION(spl_array)
18031806

18041807
spl_ce_ArrayIterator = register_class_ArrayIterator(spl_ce_SeekableIterator, zend_ce_arrayaccess, zend_ce_serializable, zend_ce_countable);
18051808
spl_ce_ArrayIterator->create_object = spl_array_object_new;
1806-
spl_ce_ArrayIterator->default_object_handlers = &spl_handler_ArrayIterator;
18071809
spl_ce_ArrayIterator->get_iterator = spl_array_get_iterator;
18081810

18091811
memcpy(&spl_handler_ArrayIterator, &spl_handler_ArrayObject, sizeof(zend_object_handlers));

ext/spl/spl_dllist.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,11 +344,14 @@ static zend_object *spl_dllist_object_new_ex(zend_class_entry *class_type, zend_
344344
while (parent) {
345345
if (parent == spl_ce_SplStack) {
346346
intern->flags |= (SPL_DLLIST_IT_FIX | SPL_DLLIST_IT_LIFO);
347+
intern->std.handlers = &spl_handler_SplDoublyLinkedList;
347348
} else if (parent == spl_ce_SplQueue) {
348349
intern->flags |= SPL_DLLIST_IT_FIX;
350+
intern->std.handlers = &spl_handler_SplDoublyLinkedList;
349351
}
350352

351353
if (parent == spl_ce_SplDoublyLinkedList) {
354+
intern->std.handlers = &spl_handler_SplDoublyLinkedList;
352355
break;
353356
}
354357

@@ -1254,7 +1257,6 @@ PHP_MINIT_FUNCTION(spl_dllist) /* {{{ */
12541257
zend_ce_iterator, zend_ce_countable, zend_ce_arrayaccess, zend_ce_serializable
12551258
);
12561259
spl_ce_SplDoublyLinkedList->create_object = spl_dllist_object_new;
1257-
spl_ce_SplDoublyLinkedList->default_object_handlers = &spl_handler_SplDoublyLinkedList;
12581260
spl_ce_SplDoublyLinkedList->get_iterator = spl_dllist_get_iterator;
12591261

12601262
memcpy(&spl_handler_SplDoublyLinkedList, &std_object_handlers, sizeof(zend_object_handlers));

ext/spl/spl_fixedarray.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,6 +282,7 @@ static zend_object *spl_fixedarray_object_new_ex(zend_class_entry *class_type, z
282282

283283
while (parent) {
284284
if (parent == spl_ce_SplFixedArray) {
285+
intern->std.handlers = &spl_handler_SplFixedArray;
285286
break;
286287
}
287288

@@ -958,7 +959,6 @@ PHP_MINIT_FUNCTION(spl_fixedarray)
958959
spl_ce_SplFixedArray = register_class_SplFixedArray(
959960
zend_ce_aggregate, zend_ce_arrayaccess, zend_ce_countable, php_json_serializable_ce);
960961
spl_ce_SplFixedArray->create_object = spl_fixedarray_new;
961-
spl_ce_SplFixedArray->default_object_handlers = &spl_handler_SplFixedArray;
962962
spl_ce_SplFixedArray->get_iterator = spl_fixedarray_get_iterator;
963963

964964
memcpy(&spl_handler_SplFixedArray, &std_object_handlers, sizeof(zend_object_handlers));

ext/spl/spl_heap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,6 +428,7 @@ static zend_object *spl_heap_object_new_ex(zend_class_entry *class_type, zend_ob
428428
while (parent) {
429429
if (parent == spl_ce_SplPriorityQueue) {
430430
intern->heap = spl_ptr_heap_init(spl_ptr_pqueue_elem_cmp, spl_ptr_heap_pqueue_elem_ctor, spl_ptr_heap_pqueue_elem_dtor, sizeof(spl_pqueue_elem));
431+
intern->std.handlers = &spl_handler_SplPriorityQueue;
431432
intern->flags = SPL_PQUEUE_EXTR_DATA;
432433
break;
433434
}
@@ -437,6 +438,7 @@ static zend_object *spl_heap_object_new_ex(zend_class_entry *class_type, zend_ob
437438
intern->heap = spl_ptr_heap_init(
438439
parent == spl_ce_SplMinHeap ? spl_ptr_heap_zval_min_cmp : spl_ptr_heap_zval_max_cmp,
439440
spl_ptr_heap_zval_ctor, spl_ptr_heap_zval_dtor, sizeof(zval));
441+
intern->std.handlers = &spl_handler_SplHeap;
440442
break;
441443
}
442444

@@ -1127,7 +1129,6 @@ PHP_MINIT_FUNCTION(spl_heap) /* {{{ */
11271129
{
11281130
spl_ce_SplHeap = register_class_SplHeap(zend_ce_iterator, zend_ce_countable);
11291131
spl_ce_SplHeap->create_object = spl_heap_object_new;
1130-
spl_ce_SplHeap->default_object_handlers = &spl_handler_SplHeap;
11311132
spl_ce_SplHeap->get_iterator = spl_heap_get_iterator;
11321133

11331134
memcpy(&spl_handler_SplHeap, &std_object_handlers, sizeof(zend_object_handlers));
@@ -1148,7 +1149,6 @@ PHP_MINIT_FUNCTION(spl_heap) /* {{{ */
11481149

11491150
spl_ce_SplPriorityQueue = register_class_SplPriorityQueue(zend_ce_iterator, zend_ce_countable);
11501151
spl_ce_SplPriorityQueue->create_object = spl_heap_object_new;
1151-
spl_ce_SplPriorityQueue->default_object_handlers = &spl_handler_SplPriorityQueue;
11521152
spl_ce_SplPriorityQueue->get_iterator = spl_pqueue_get_iterator;
11531153

11541154
memcpy(&spl_handler_SplPriorityQueue, &std_object_handlers, sizeof(zend_object_handlers));

0 commit comments

Comments
 (0)