Skip to content

Commit d0006b5

Browse files
committed
Use UNKNOWN default for socket_connect()
Specifying the port is mandatory for INET sockets.
1 parent b9b2e8d commit d0006b5

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

ext/sockets/sockets.stub.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function socket_getpeername($socket, &$addr, &$port = UNKNOWN): bool {}
4141
function socket_create(int $domain, int $type, int $protocol) {}
4242

4343
/** @param resource $socket */
44-
function socket_connect($socket, string $addr, int $port = 0): bool {}
44+
function socket_connect($socket, string $addr, int $port = UNKNOWN): bool {}
4545

4646
function socket_strerror(int $errno): string {}
4747

ext/sockets/sockets_arginfo.h

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,18 @@ ZEND_END_ARG_INFO()
6161
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_socket_connect, 0, 2, _IS_BOOL, 0)
6262
ZEND_ARG_INFO(0, socket)
6363
ZEND_ARG_TYPE_INFO(0, addr, IS_STRING, 0)
64-
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, port, IS_LONG, 0, "0")
64+
ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 0)
6565
ZEND_END_ARG_INFO()
6666

6767
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_socket_strerror, 0, 1, IS_STRING, 0)
6868
ZEND_ARG_TYPE_INFO(0, errno, IS_LONG, 0)
6969
ZEND_END_ARG_INFO()
7070

71-
#define arginfo_socket_bind arginfo_socket_connect
71+
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_socket_bind, 0, 2, _IS_BOOL, 0)
72+
ZEND_ARG_INFO(0, socket)
73+
ZEND_ARG_TYPE_INFO(0, addr, IS_STRING, 0)
74+
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, port, IS_LONG, 0, "0")
75+
ZEND_END_ARG_INFO()
7276

7377
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_socket_recv, 0, 4, MAY_BE_LONG|MAY_BE_FALSE)
7478
ZEND_ARG_INFO(0, socket)

0 commit comments

Comments
 (0)