Skip to content

Commit cfffbfa

Browse files
committed
Remove dead code
1 parent f44eaac commit cfffbfa

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

ext/mysqlnd/mysqlnd_wireprotocol.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2615,7 +2615,7 @@ static enum_func_status
26152615
MYSQLND_METHOD(mysqlnd_protocol, send_command_handle_response)(
26162616
MYSQLND_PROTOCOL_PAYLOAD_DECODER_FACTORY * payload_decoder_factory,
26172617
const enum mysqlnd_packet_type ok_packet,
2618-
const bool silent,
2618+
const bool silent, /* This is a dead parameter */
26192619
const enum php_mysqlnd_server_command command,
26202620
const bool ignore_upsert_status, /* actually used only by LOAD DATA. COM_QUERY and COM_EXECUTE handle the responses themselves */
26212621

@@ -2638,12 +2638,8 @@ MYSQLND_METHOD(mysqlnd_protocol, send_command_handle_response)(
26382638
break;
26392639
default:
26402640
SET_CLIENT_ERROR(error_info, CR_MALFORMED_PACKET, UNKNOWN_SQLSTATE, "Malformed packet");
2641-
php_error_docref(NULL, E_ERROR, "Wrong response packet %u passed to the function", ok_packet);
26422641
break;
26432642
}
2644-
if (!silent && error_info->error_no == CR_MALFORMED_PACKET) {
2645-
php_error_docref(NULL, E_WARNING, "Error while reading %s's response packet. PID=%d", mysqlnd_command_to_text[command], getpid());
2646-
}
26472643
DBG_INF(ret == PASS ? "PASS":"FAIL");
26482644
DBG_RETURN(ret);
26492645
}

0 commit comments

Comments
 (0)