Add ini_bytes to translate ini directive byte shorthand to a count

With WordPress we have seen a variety of bugs that stem from the fact that we
don't reliably parse the memory size values from php.ini directives. We want
to know those values in order to communicate to site users what the file
upload limits are.

In this patch I'm adding a new function `ini_bytes( $shorthand )` to return
whatever PHP evaluates that value to be internally, thus exposing the actual
byte size to the outside world. This eliminates the need for WordPress and
other projects to port the config value parser since they could directly
call it. Additionally it will reliably reproduce any quirks due to the
platform build and overflow behaviors when handling the `g`, `m`, and `k`
suffixes on `post_max_size` and `upload_max_filesize` (and others).

This function is a shallow wrapper around `zend_atoi()` and could become
out of sync with the actual ini directive parsing. I considered a variation
of this function which would take a directive's name and return the stored
internal value directly, keeping it in sync.

```php
switch ( param_name ) {
	case 'post_max_size':
		RETVAL_LONG(SG(post_max_size));
}
```

After looking briefly at this option I dismissed it for being a bit too
coupled to those options, too demanding to add all the possible config
options to a big switch statement, and too complicated for returning all
of the possible return types stored in the SAPI globals.

This is my first attempt at patching PHP and I don't know what I'm doing :)
I'm not thrilled at the function name but I needed something.
I'm not aware of what I need to write for testing, documentation, etc...
but I'm happy to add whatever is required.

The expecation is to use it in situations roughly like this:

```php
function max_upload_size() {
	$u_bytes = ini_bytes( ini_get( 'upload_max_filesize' ) || 0 );
	$p_bytes = ini_bytes( ini_get( 'post_max_size' ) || 0 );

	return min( $u_bytes, $p_bytes );
}
```

This patch also makes it easier to perform mathematic comparisons and
operations on the config values, which again previously required duplicating
the parsing outside of PHP and likely will fail for a variety of config values.

```php
function validate_upload_size() {
	$u_bytes = ini_bytes( ini_get( 'upload_max_filesize' ) || 0 );
	$p_bytes = ini_bytes( ini_get( 'post_max_size' ) || 0 );

	return $u_bytes <= $p_bytes
		? [ true ]
		: [ false, 'upload_max_filesize must be smaller than post_max_size' ];
}
```

Author: dmsnell

ext/standard/basic_functions.c

@@ -1970,6 +1970,20 @@ PHP_FUNCTION(highlight_string)
 }
 /* }}} */
 
+/* {{{ Get a byte size from the ini byte size shorthand */
+PHP_FUNCTION(ini_bytes)
+{
+	char *shorthand;
+	size_t shorthand_len;
+
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_STRING(shorthand, shorthand_len)
+	ZEND_PARSE_PARAMETERS_END();
+
+	RETVAL_LONG(zend_atol(shorthand, shorthand_len));
+}
+/* }}} */
+
 /* {{{ Get a configuration option */
 PHP_FUNCTION(ini_get)
 {

ext/standard/basic_functions.stub.php

@@ -499,6 +499,8 @@ function ini_alter(string $option, string|int|float|bool|null $value): string|fa
 
 function ini_restore(string $option): void {}
 
+function ini_bytes(string $option): int {}
+
 /** @refcount 1 */
 function set_include_path(string $include_path): string|false {}
 

ext/standard/basic_functions_arginfo.h

@@ -484,6 +484,10 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ini_get, 0, 1, MAY_BE_STRING|MAY
 	ZEND_ARG_TYPE_INFO(0, option, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ini_bytes, 0, 1, MAY_BE_LONG)
+	ZEND_ARG_TYPE_INFO(0, option, IS_STRING, 0)
+ZEND_END_ARG_INFO()
+
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_ini_get_all, 0, 0, MAY_BE_ARRAY|MAY_BE_FALSE)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, extension, IS_STRING, 1, "null")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, details, _IS_BOOL, 0, "true")
@@ -2354,6 +2358,7 @@ ZEND_FUNCTION(highlight_file);
 ZEND_FUNCTION(php_strip_whitespace);
 ZEND_FUNCTION(highlight_string);
 ZEND_FUNCTION(ini_get);
+ZEND_FUNCTION(ini_bytes);
 ZEND_FUNCTION(ini_get_all);
 ZEND_FUNCTION(ini_set);
 ZEND_FUNCTION(ini_restore);
@@ -2985,6 +2990,7 @@ static const zend_function_entry ext_functions[] = {
 	ZEND_FE(php_strip_whitespace, arginfo_php_strip_whitespace)
 	ZEND_FE(highlight_string, arginfo_highlight_string)
 	ZEND_FE(ini_get, arginfo_ini_get)
+	ZEND_FE(ini_bytes, arginfo_ini_bytes)
 	ZEND_FE(ini_get_all, arginfo_ini_get_all)
 	ZEND_FE(ini_set, arginfo_ini_set)
 	ZEND_FALIAS(ini_alter, ini_set, arginfo_ini_alter)