Skip to content

Commit cf7c592

Browse files
committed
Simplify property check in php_libxml_node_free_resource()
1 parent 974edc7 commit cf7c592

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

ext/libxml/libxml.c

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1406,18 +1406,8 @@ PHP_LIBXML_API void php_libxml_node_free_resource(xmlNodePtr node)
14061406
default:
14071407
if (node->parent == NULL || node->type == XML_NAMESPACE_DECL) {
14081408
php_libxml_node_free_list((xmlNodePtr) node->children);
1409-
switch (node->type) {
1410-
/* Skip property freeing for the following types */
1411-
case XML_ATTRIBUTE_DECL:
1412-
case XML_DTD_NODE:
1413-
case XML_DOCUMENT_TYPE_NODE:
1414-
case XML_ENTITY_DECL:
1415-
case XML_ATTRIBUTE_NODE:
1416-
case XML_NAMESPACE_DECL:
1417-
case XML_TEXT_NODE:
1418-
break;
1419-
default:
1420-
php_libxml_node_free_list((xmlNodePtr) node->properties);
1409+
if (node->type == XML_ELEMENT_NODE) {
1410+
php_libxml_node_free_list((xmlNodePtr) node->properties);
14211411
}
14221412
php_libxml_unregister_node(node);
14231413
php_libxml_node_free(node);

0 commit comments

Comments
 (0)