ext/ldap: fix leak on port overflow check.

devnexen · devnexen · commit cb8e659ca9e4 · 2025-05-24T21:09:53.000+01:00
diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c
@@ -994,6 +994,7 @@ PHP_FUNCTION(ldap_connect)
 			size_t urllen = hostlen + sizeof( "ldap://:65535" );
 
 			if (port <= 0 || port > 65535) {
+				zval_ptr_dtor(return_value);
 				zend_argument_value_error(2, "must be between 1 and 65535");
 				RETURN_THROWS();
 			}

Original file line number	Diff line number	Diff line change
`@@ -994,6 +994,7 @@ PHP_FUNCTION(ldap_connect)`
`994`	`994`	`size_t urllen = hostlen + sizeof( "ldap://:65535" );`
`995`	`995`
`996`	`996`	`if (port <= 0 \|\| port > 65535) {`
	`997`	`+ zval_ptr_dtor(return_value);`
`997`	`998`	`zend_argument_value_error(2, "must be between 1 and 65535");`
`998`	`999`	`RETURN_THROWS();`
`999`	`1000`	`}`