Skip to content

Commit c9fa625

Browse files
committed
Merge branch 'PHP-8.4'
* PHP-8.4: Fixed GH-17398: bcmul memory leak (#17615)
2 parents b0abb49 + 4c90bb2 commit c9fa625

File tree

4 files changed

+22
-3
lines changed

4 files changed

+22
-3
lines changed

ext/bcmath/bcmath.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,9 @@ static PHP_GINIT_FUNCTION(bcmath)
109109
/* {{{ PHP_GSHUTDOWN_FUNCTION */
110110
static PHP_GSHUTDOWN_FUNCTION(bcmath)
111111
{
112-
_bc_free_num_ex(&bcmath_globals->_zero_, 1);
113-
_bc_free_num_ex(&bcmath_globals->_one_, 1);
114-
_bc_free_num_ex(&bcmath_globals->_two_, 1);
112+
bc_force_free_number(&bcmath_globals->_zero_);
113+
bc_force_free_number(&bcmath_globals->_one_);
114+
bc_force_free_number(&bcmath_globals->_two_);
115115
bcmath_globals->arena = NULL;
116116
bcmath_globals->arena_offset = 0;
117117
}

ext/bcmath/libbcmath/src/bcmath.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,8 @@ typedef struct bc_struct {
7878

7979
void bc_init_numbers(void);
8080

81+
void bc_force_free_number(bc_num *num);
82+
8183
bc_num _bc_new_num_ex(size_t length, size_t scale, bool persistent);
8284

8385
bc_num _bc_new_num_nonzeroed_ex(size_t length, size_t scale, bool persistent);

ext/bcmath/libbcmath/src/init.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,13 @@ void bc_init_numbers(void)
9797
BCG(_two_)->n_value[0] = 2;
9898
}
9999

100+
void bc_force_free_number(bc_num *num)
101+
{
102+
pefree((*num)->n_ptr, 1);
103+
pefree(*num, 1);
104+
*num = NULL;
105+
}
106+
100107

101108
/* Initialize a number NUM by making it a copy of zero. */
102109
void bc_init_num(bc_num *num)

ext/bcmath/tests/gh17398.phpt

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
--TEST--
2+
GH-17398 (bcmul memory leak)
3+
--EXTENSIONS--
4+
bcmath
5+
--FILE--
6+
<?php
7+
bcmul('0', '0', 2147483647);
8+
?>
9+
--EXPECTF--
10+
Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d

0 commit comments

Comments
 (0)