Skip to content

Commit c7da9d3

Browse files
committed
opcache optimizer: optimize some more functions on compile time
don't optimize basename(), version_compare(string, string, string)
1 parent a935c23 commit c7da9d3

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

ext/opcache/Optimizer/sccp.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,6 @@ static inline int ct_eval_func_call(
846846
|| zend_string_equals_literal(name, "rawurldecode")
847847
|| zend_string_equals_literal(name, "php_uname")
848848
|| zend_string_equals_literal(name, "dirname")
849-
|| zend_string_equals_literal(name, "basename")
850849
|| zend_string_equals_literal(name, "md5")
851850
|| zend_string_equals_literal(name, "crc32")
852851
|| zend_string_equals_literal(name, "sha1")) {
@@ -975,8 +974,7 @@ static inline int ct_eval_func_call(
975974
|| zend_string_equals_literal(name, "str_contains")
976975
|| zend_string_equals_literal(name, "str_starts_with")
977976
|| zend_string_equals_literal(name, "str_ends_with")
978-
|| zend_string_equals_literal(name, "version_compare")
979-
|| zend_string_equals_literal(name, "basename")) {
977+
|| zend_string_equals_literal(name, "version_compare")) {
980978
if (Z_TYPE_P(args[0]) != IS_STRING
981979
|| Z_TYPE_P(args[1]) != IS_STRING) {
982980
return FAILURE;
@@ -1018,8 +1016,7 @@ static inline int ct_eval_func_call(
10181016
}
10191017
}
10201018
/* pass */
1021-
} else if (zend_string_equals_literal(name, "version_compare")
1022-
|| zend_string_equals_literal(name, "str_replace")) {
1019+
} else if (zend_string_equals_literal(name, "str_replace")) {
10231020
if (Z_TYPE_P(args[0]) != IS_STRING
10241021
|| Z_TYPE_P(args[1]) != IS_STRING
10251022
|| Z_TYPE_P(args[2]) != IS_STRING) {

0 commit comments

Comments
 (0)