Code review fixes

Author: nielsdos

ext/dom/document.c

@@ -1197,7 +1197,7 @@ const char *_dom_get_valid_file_path(const char *source, char *resolved_path, in
 }
 /* }}} */
 
-xmlDocPtr dom_document_parser(zval *id, int mode, const char *source, size_t source_len, size_t options, xmlCharEncodingHandlerPtr encoding) /* {{{ */
+xmlDocPtr dom_document_parser(zval *id, dom_load_mode mode, const char *source, size_t source_len, size_t options, xmlCharEncodingHandlerPtr encoding) /* {{{ */
 {
 	xmlDocPtr ret;
 	xmlParserCtxtPtr ctxt = NULL;

ext/dom/php_dom.h

@@ -160,10 +160,12 @@ void php_dom_document_constructor(INTERNAL_FUNCTION_PARAMETERS);
 
 dom_object *php_dom_instantiate_object_helper(zval *return_value, zend_class_entry *ce, xmlNodePtr obj, dom_object *parent);
 
-#define DOM_LOAD_STRING 0
-#define DOM_LOAD_FILE 1
+typedef enum {
+	DOM_LOAD_STRING = 0,
+	DOM_LOAD_FILE = 1,
+} dom_load_mode;
 
-xmlDocPtr dom_document_parser(zval *id, int mode, const char *source, size_t source_len, size_t options, xmlCharEncodingHandlerPtr encoding);
+xmlDocPtr dom_document_parser(zval *id, dom_load_mode mode, const char *source, size_t source_len, size_t options, xmlCharEncodingHandlerPtr encoding);
 
 /* parentnode */
 void dom_parent_node_prepend(dom_object *context, zval *nodes, uint32_t nodesc);

ext/dom/xml_document.c

@@ -193,7 +193,7 @@ static void load_from_helper(INTERNAL_FUNCTION_PARAMETERS, int mode)
 	}
 
 	if (ZEND_SIZE_T_INT_OVFL(source_len)) {
-		zend_argument_value_error(1, "must not exceed INT_MAX in length");
+		zend_argument_value_error(1, "is too long");
 		RETURN_THROWS();
 	}