Skip to content

Commit c756e97

Browse files
mvorisekcmb69
authored andcommitted
Improve tests on 32bit
The watch_*.phpt test apparently no longer fail on 32bit, so we remove the XFAIL conditions. bug77269.phpt is practically identical to bug77272.phpt, and there seems no particular reason to have an additional test for libgd ≤ 2.2.5. Closes GH-8448.
1 parent e01586a commit c756e97

File tree

5 files changed

+0
-31
lines changed

5 files changed

+0
-31
lines changed

ext/gd/tests/bug77269.phpt

Lines changed: 0 additions & 19 deletions
This file was deleted.

sapi/phpdbg/tests/watch_001.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
Test simple recursive watchpoint
33
--SKIPIF--
44
<?php
5-
if (PHP_INT_SIZE == 4) {
6-
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
7-
}
85
if (getenv('SKIP_ASAN')) {
96
die("skip intentionally causes segfaults");
107
}

sapi/phpdbg/tests/watch_002.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
Test simple array watchpoint with replace
33
--SKIPIF--
44
<?php
5-
if (PHP_INT_SIZE == 4) {
6-
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
7-
}
85
if (getenv('SKIP_ASAN')) {
96
die("skip intentionally causes segfaults");
107
}

sapi/phpdbg/tests/watch_003.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
Test simple watchpoint with replace
33
--SKIPIF--
44
<?php
5-
if (PHP_INT_SIZE == 4) {
6-
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
7-
}
85
if (getenv('SKIP_ASAN')) {
96
die("skip intentionally causes segfaults");
107
}

sapi/phpdbg/tests/watch_004.phpt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
Test detection of inline string manipulations on zval watch
33
--SKIPIF--
44
<?php
5-
if (PHP_INT_SIZE == 4) {
6-
die("xfail There may be flaws in the implementation of watchpoints that cause failures");
7-
}
85
if (getenv('SKIP_ASAN')) {
96
die("skip intentionally causes segfaults");
107
}

0 commit comments

Comments
 (0)