Skip to content

Commit c6b5352

Browse files
committed
Include 'PHP Request Startup' in error messages
1 parent e32a409 commit c6b5352

File tree

6 files changed

+13
-11
lines changed

6 files changed

+13
-11
lines changed

ext/mbstring/tests/bug63447_001.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ a=1&b=2&c=3&d=4&e=5&f=6
1515
var_dump($_POST);
1616
?>
1717
--EXPECT--
18-
Warning: Unknown: Input variables exceeded 5. To increase the limit change max_input_vars in php.ini. in Unknown on line 0
18+
Warning: PHP Request Startup: Input variables exceeded 5. To increase the limit change max_input_vars in php.ini. in Unknown on line 0
1919
array(0) {
2020
}

ext/mbstring/tests/bug63447_002.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ a=1&b=2&c=3&d=4&e=5
1515
var_dump($_POST);
1616
?>
1717
--EXPECT--
18-
Warning: Unknown: Input variables exceeded 4. To increase the limit change max_input_vars in php.ini. in Unknown on line 0
18+
Warning: PHP Request Startup: Input variables exceeded 4. To increase the limit change max_input_vars in php.ini. in Unknown on line 0
1919
array(0) {
2020
}

ext/session/tests/rfc1867_sid_invalid.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,17 @@ var_dump($_SESSION["upload_progress_" . basename(__FILE__)]);
4848
session_destroy();
4949
?>
5050
--EXPECTF--
51-
Warning: Unknown: The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in Unknown on line 0
51+
Warning: PHP Request Startup: The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in Unknown on line 0
5252

53-
Warning: Unknown: Failed to read session data: files (path: ) in Unknown on line 0
53+
Warning: PHP Request Startup: Failed to read session data: files (path: ) in Unknown on line 0
5454

55-
Warning: Unknown: Failed to write session data (files). Please verify that the current setting of session.save_path is correct () in Unknown on line 0
55+
Warning: PHP Request Startup: Failed to write session data (files). Please verify that the current setting of session.save_path is correct () in Unknown on line 0
5656

57-
Warning: Unknown: The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in Unknown on line 0
57+
Warning: PHP Request Startup: The session id is too long or contains illegal characters, valid characters are a-z, A-Z, 0-9 and '-,' in Unknown on line 0
5858

59-
Warning: Unknown: Failed to read session data: files (path: ) in Unknown on line 0
59+
Warning: PHP Request Startup: Failed to read session data: files (path: ) in Unknown on line 0
6060

61-
Warning: Unknown: Failed to write session data (files). Please verify that the current setting of session.save_path is correct () in Unknown on line 0
61+
Warning: PHP Request Startup: Failed to write session data (files). Please verify that the current setting of session.save_path is correct () in Unknown on line 0
6262
string(%d) ""
6363
bool(true)
6464
array(2) {

main/main.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -984,6 +984,8 @@ PHPAPI ZEND_COLD void php_verror(const char *docref, const char *params, int typ
984984
function = "PHP Startup";
985985
} else if (php_during_module_shutdown()) {
986986
function = "PHP Shutdown";
987+
} else if (PG(during_request_startup)) {
988+
function = "PHP Request Startup";
987989
} else if (EG(current_execute_data) &&
988990
EG(current_execute_data)->func &&
989991
ZEND_USER_CODE(EG(current_execute_data)->func->common.type) &&

sapi/cgi/tests/bug69487.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ var_dump(isset($_POST['foo']));
1111
var_dump(strlen(file_get_contents('php://input')));
1212
?>
1313
--EXPECT--
14-
Warning: Unknown: Unable to create temporary file, Check permissions in temporary files directory. in Unknown on line 0
14+
Warning: PHP Request Startup: Unable to create temporary file, Check permissions in temporary files directory. in Unknown on line 0
1515

16-
Warning: Unknown: POST data can't be buffered; all data discarded in Unknown on line 0
16+
Warning: PHP Request Startup: POST data can't be buffered; all data discarded in Unknown on line 0
1717
bool(false)
1818
int(0)

tests/basic/025.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ a=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
1111
var_dump($_POST, $HTTP_RAW_POST_DATA);
1212
?>
1313
--EXPECTF--
14-
Warning: Unknown: POST Content-Length of 2050 bytes exceeds the limit of 1024 bytes in Unknown on line 0
14+
Warning: PHP Request Startup: POST Content-Length of 2050 bytes exceeds the limit of 1024 bytes in Unknown on line 0
1515

1616
Warning: Undefined variable: HTTP_RAW_POST_DATA in %s on line %d
1717
array(0) {

0 commit comments

Comments
 (0)