Mark several phpdbg tests as xfail

cmb69 · cmb69 · commit c5cf0af8a98c · 2020-05-27T11:39:15.000+02:00
Apparently, breakpoints and watchpoints are practically disabled if
run with OPcache JIT under Windows, so we mark the affected tests as
xfail in that case for the time being.
diff --git a/sapi/phpdbg/tests/breakpoints_001.phpt b/sapi/phpdbg/tests/breakpoints_001.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Fundamental breakpoints functionality
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b 3
 r
diff --git a/sapi/phpdbg/tests/breakpoints_002.phpt b/sapi/phpdbg/tests/breakpoints_002.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Preserve breakpoints on restart
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b breakpoints_002.php:4
 r
diff --git a/sapi/phpdbg/tests/breakpoints_003.phpt b/sapi/phpdbg/tests/breakpoints_003.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Test deleting breakpoints
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b 4
 b del 0
diff --git a/sapi/phpdbg/tests/breakpoints_004.phpt b/sapi/phpdbg/tests/breakpoints_004.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Test opcode breakpoints
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b ZEND_ECHO
 r
diff --git a/sapi/phpdbg/tests/exceptions_003.phpt b/sapi/phpdbg/tests/exceptions_003.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Test breaks on HANDLE_EXCEPTION
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b 5
 r
diff --git a/sapi/phpdbg/tests/finish_leave_001.phpt b/sapi/phpdbg/tests/finish_leave_001.phpt
@@ -1,5 +1,11 @@
 --TEST--
 test finish and leave commands
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --INI--
 opcache.optimization_level=0
 --PHPDBG--
diff --git a/sapi/phpdbg/tests/info_002.phpt b/sapi/phpdbg/tests/info_002.phpt
@@ -1,5 +1,11 @@
 --TEST--
 info constants test
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b 10
 r
diff --git a/sapi/phpdbg/tests/next_001.phpt b/sapi/phpdbg/tests/next_001.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Test next command on function boundaries
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 b 4
 r
diff --git a/sapi/phpdbg/tests/phpdbg_break_next.phpt b/sapi/phpdbg/tests/phpdbg_break_next.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Test phpdbg_break_next() function
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 r
 c
diff --git a/sapi/phpdbg/tests/run_002.phpt b/sapi/phpdbg/tests/run_002.phpt
@@ -1,5 +1,11 @@
 --TEST--
 Stdin and escaped args being passed to run command
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --CLEAN--
 <?php
 @unlink("run_002_tmp.fixture");
diff --git a/sapi/phpdbg/tests/set_exception_handler.phpt b/sapi/phpdbg/tests/set_exception_handler.phpt
@@ -1,5 +1,11 @@
 --TEST--
 set_exception_handler() in phpdbg
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
+?>
 --PHPDBG--
 r
 c
diff --git a/sapi/phpdbg/tests/watch_001.phpt b/sapi/phpdbg/tests/watch_001.phpt
@@ -5,6 +5,9 @@ Test simple recursive watchpoint
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }
diff --git a/sapi/phpdbg/tests/watch_002.phpt b/sapi/phpdbg/tests/watch_002.phpt
@@ -5,6 +5,9 @@ Test simple array watchpoint with replace
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }
diff --git a/sapi/phpdbg/tests/watch_003.phpt b/sapi/phpdbg/tests/watch_003.phpt
@@ -5,6 +5,9 @@ Test simple watchpoint with replace
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }
diff --git a/sapi/phpdbg/tests/watch_004.phpt b/sapi/phpdbg/tests/watch_004.phpt
@@ -5,6 +5,9 @@ Test detection of inline string manipulations on zval watch
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }
diff --git a/sapi/phpdbg/tests/watch_005.phpt b/sapi/phpdbg/tests/watch_005.phpt
@@ -5,6 +5,9 @@ Test proper watch comparisons when having multiple levels of indirection from a
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }
diff --git a/sapi/phpdbg/tests/watch_006.phpt b/sapi/phpdbg/tests/watch_006.phpt
@@ -5,6 +5,9 @@ Test multiple watch elements pointing to the same watchpoint
 if (PHP_INT_SIZE == 4) {
     die("xfail There may be flaws in the implementation of watchpoints that cause failures");
 }
+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {
+    die('xfail breakpoint/watchpoint issues with JIT on Windows');
+}
 if (getenv('SKIP_ASAN')) {
     die("skip intentionally causes segfaults");
 }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,11 @@`
`1`	`1`	`--TEST--`
`2`	`2`	`Test phpdbg_break_next() function`
	`3`	`+--SKIPIF--`
	`4`	`+<?php`
	`5`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`6`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`7`	`+}`
	`8`	`+?>`
`3`	`9`	`--PHPDBG--`
`4`	`10`	`r`
`5`	`11`	`c`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,11 @@`
`1`	`1`	`--TEST--`
`2`	`2`	`set_exception_handler() in phpdbg`
	`3`	`+--SKIPIF--`
	`4`	`+<?php`
	`5`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`6`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`7`	`+}`
	`8`	`+?>`
`3`	`9`	`--PHPDBG--`
`4`	`10`	`r`
`5`	`11`	`c`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test simple recursive watchpoint`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test simple array watchpoint with replace`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test simple watchpoint with replace`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test detection of inline string manipulations on zval watch`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test proper watch comparisons when having multiple levels of indirection from a`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,9 @@ Test multiple watch elements pointing to the same watchpoint`
`5`	`5`	`if (PHP_INT_SIZE == 4) {`
`6`	`6`	`die("xfail There may be flaws in the implementation of watchpoints that cause failures");`
`7`	`7`	`}`
	`8`	`+if (PHP_OS_FAMILY === 'Windows' && ini_get('opcache.jit') && ini_get('opcache.jit_buffer_size')) {`
	`9`	`+ die('xfail breakpoint/watchpoint issues with JIT on Windows');`
	`10`	`+}`
`8`	`11`	`if (getenv('SKIP_ASAN')) {`
`9`	`12`	`die("skip intentionally causes segfaults");`
`10`	`13`	`}`