Initialize ping_auto_globals_mask to prevent undefined behaviour

nielsdos · iluuu1994 · commit c4487b7a12bf · 2022-12-22T14:59:24.000+01:00
Closes GH-10121
diff --git a/NEWS b/NEWS
@@ -15,6 +15,7 @@ PHP                                                                        NEWS
 
 - Opcache:
   . Fix inverted bailout value in zend_runtime_jit() (Max Kellermann).
+  . Fix access to uninitialized variable in accel_preload(). (nielsdos)
 
 - TSRM:
   . Fixed Windows shmget() wrt. IPC_PRIVATE. (Tyson Andre)
diff --git a/ext/opcache/ZendAccelerator.c b/ext/opcache/ZendAccelerator.c
@@ -4444,6 +4444,8 @@ static int accel_preload(const char *config, bool in_child)
 
 		if (PG(auto_globals_jit)) {
 			ping_auto_globals_mask = zend_accel_get_auto_globals();
+		} else {
+			ping_auto_globals_mask = 0;
 		}
 
 		if (EG(zend_constants)) {

Original file line number	Diff line number	Diff line change
`@@ -4444,6 +4444,8 @@ static int accel_preload(const char *config, bool in_child)`
`4444`	`4444`
`4445`	`4445`	`if (PG(auto_globals_jit)) {`
`4446`	`4446`	`ping_auto_globals_mask = zend_accel_get_auto_globals();`
	`4447`	`+ } else {`
	`4448`	`+ ping_auto_globals_mask = 0;`
`4447`	`4449`	`}`
`4448`	`4450`
`4449`	`4451`	`if (EG(zend_constants)) {`